Skip to content

[vector.bool] Excise use of undefined term 'conversion operator' #1018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2016
Merged

[vector.bool] Excise use of undefined term 'conversion operator' #1018

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion source/compatibility.tex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1289,7 +1289,7 @@
\ref{istream::sentry},
\ref{ostream::sentry},
\ref{iostate.flags}
\change Specify use of explicit in existing boolean conversion operators
\change Specify use of explicit in existing boolean conversion functions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should "explicit" appear in code font, since it's actually a keyword?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but I shouldn't make that change here, which deals with "conversion operator" vs. "conversion function".

I've created #1019 to deal with the "explicit" code font issue.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, sure, but I would have had no problem with a minor drive-by fix like that if this is a single, isolated problem. You can stick it into a separate commit in the same pull request, and I could retain the separate commits (i.e. not squash them), so we still get nicely atomic commits.

\rationale Clarify intentions, avoid workarounds.
\effect
Valid \CppIII code that relies on implicit boolean conversions will fail to
Expand Down
2 changes: 1 addition & 1 deletion source/containers.tex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5701,7 +5701,7 @@
\pnum
\tcode{reference}
is a class that simulates the behavior of references of a single bit in
\tcode{vector<bool>}. The conversion operator returns \tcode{true}
\tcode{vector<bool>}. The conversion function returns \tcode{true}
when the bit is set, and \tcode{false} otherwise. The assignment operator
sets the bit when the argument is (convertible to) \tcode{true} and
clears it otherwise. \tcode{flip} reverses the state of the bit.
Expand Down
1 change: 0 additions & 1 deletion source/special.tex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -799,7 +799,6 @@
\indextext{function!conversion}%
\indextext{fundamental~type~conversion|see{conversion, user-defined}}%
\indextext{conversion!user-defined}%
\indextext{conversion operator|see{conversion, user defined}}

\pnum
A member function of a class \tcode{X} having no parameters with a name of the form
Expand Down