Skip to content

Make DatabaseManager a Koin singleton #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 6, 2023
Merged

Make DatabaseManager a Koin singleton #42

merged 2 commits into from
Jun 6, 2023

Conversation

jeffdgr8
Copy link
Contributor

@jeffdgr8
Make DatabaseManager a Koin singleton
75d7a74 
Use Koin constructor DSL
Use AndroidViewModel
@biozal
Copy link
Contributor

biozal commented Dec 15, 2022

@jeffdgr8 this is a fantastic and better syntax way of handling this. I'll update the docs this weekend so we can merge this. Thanks again!

@jeffdgr8 jeffdgr8 mentioned this pull request Jan 10, 2023
Open
@bmeike
Copy link

bmeike commented Jun 5, 2023

I'm not sure what is holding this up. It is definitely the right thing to do.

I don't think I'm entitled to just merge it.... and I'm going to be out for a while. Lemme check with @biozal .

@biozal biozal merged commit 159be01 into couchbase-examples:main Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@biozal biozal biozal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeffdgr8 @biozal @bmeike