Skip to content

fix(CDataTable): issue with loading and no-items-view slots #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2021
Merged

fix(CDataTable): issue with loading and no-items-view slots #141

merged 1 commit into from
Mar 11, 2021

Conversation

alexraileanu
Copy link

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch (or to a previous version branch), not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

if loading the items in the table asynchronously and passing the loading
prop to the c-data-table, until the request would be done, the table
would display both the no-item-slot and the loading slot. this fix
changes it so that while loading, do not display the no-items-slot

if loading the items in the table asynchronously and passing the loading
prop to the c-data-table, until the request would be done, the table
would display both the no-item-slot and the loading slot. this fix
changes it so that while loading, do not display the no-items-slot
@xidedix xidedix changed the title fix(CDataTable): fixed issue with loading/no-items-slot fix(CDataTable): issue with loading and no-items-view slots Mar 11, 2021
@xidedix xidedix merged commit ffe53ce into coreui:dev Mar 11, 2021
xidedix added a commit that referenced this pull request Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants