Skip to content

chore: update dependency @types/yargs to v17 #2613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 24, 2021
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 21, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@types/yargs ^16.0.0 -> ^17.0.0 age adoption passing confidence

Configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@escapedcat
Copy link
Member

Build is failing, need to be checked:
image

@escapedcat
Copy link
Member

escapedcat commented May 23, 2021

Adding blocked label to make this more visible. It's not blocked by another issue/PR.

@escapedcat
Copy link
Member

escapedcat commented May 24, 2021

I think the added Promise to the type creates our issue. Not sure:
DefinitelyTyped/DefinitelyTyped@2772f88#diff-e1c9bcedd5cf08cf3e697aef9539535d9a16d0e92f33c9a5038b3389e6490c0cR48

image
Not sure how to fix this.

I a update to the "yargs" types they added a `Promise` to the `Args`
interface. The main cli did not handle this type and failed type
checking. Now the main will handle a `Promise` by resolving it into
the `CliFlags` interface that is expected.
@AdeAttwood AdeAttwood self-assigned this May 24, 2021
@escapedcat
Copy link
Member

Thanks @AdeAttwood !

@escapedcat escapedcat merged commit b837faf into master May 24, 2021
@escapedcat escapedcat deleted the renovate/yargs-17.x branch May 24, 2021 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants