Skip to content

feat(ensure): modify enum to support regular expression #1257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions @commitlint/ensure/src/enum.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -44,3 +44,13 @@ test('false for c against a, b', () => {
const actual = ensure('c', ['a', 'b']);
expect(actual).toBe(false);
});

test('false for ensure/enum against ensure, cli', () => {
const actual = ensure('ensure/enum', ['ensure', 'cli']);
expect(actual).toBe(false);
});

test('true for ensure/enum against ensure/*, cli/*', () => {
const actual = ensure('ensure/enum', [/ensure\/*/, /cli\/*/]);
expect(actual).toBe(true);
});
8 changes: 7 additions & 1 deletion @commitlint/ensure/src/enum.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,11 @@ export default (value: any, enums: any[] = []): boolean => {
if (!Array.isArray(enums)) {
return false;
}
return enums.indexOf(value) > -1;
return enums.reduce((last, curr) => {
if (curr instanceof RegExp) {
return last || value.search(curr) !== -1;
} else {
return last || value === curr;
}
}, false);
};