Default "longer description" is always "-"

[dangreen]

Expected Behavior

Empty longer description.

Current Behavior

"longer description" is always "-"

Affected packages

• cli
• core
• prompt
• config-angular

Possible Solution

restore this

commitlint/@commitlint/cz-commitlint/src/SectionBody.ts

Line 22 in a038b41

const commitBody = body || breakingBody || issuesBody || '-';

to this

commitlint/@commitlint/cz-commitlint/src/SectionBody.ts

Line 22 in c77381d

const commitBody = body ?? breakingBody ?? issuesBody ?? '-';

Tested

Steps to Reproduce (for bugs)

1. clone https://github.com/TrigenSoftware/scripts
2. pnpm i
3. pnpm commit -- --allow-empty
4. "longer description" is "-"

Your Environment

Issue appeared in @commitlint/cz-commitlint@16.0.0

[escapedcat]

@dangreen if you changed it and all existing tests are still I green I guess we could revert this.
@honzamelena what do you think? This came from you, right? a038b41

[honzamelena]

@escapedcat @dangreen I don't think this is the solution. As you can see from the line, this behavior was always there. Unfortunately because of the wrongly used "??" instead of "||" it never actually got to the point of using "-" as the default value when all the other body types are empty was never triggered due to always having an empty body (first occurrence).

See the attached screen for the different behavior between using "??" and "||".

If we revert this, the issueBody and breakingBody will never be triggered and my newly created test in the library to check this would fail. As seen below (not sure what was tested then):

I would suggest just removing the default "-" at the end if we want to not have it there in case of an empty body supplied.

[dangreen]

@honzamelena @escapedcat How soon will you fix it?

[escapedcat]

@dangreen happy for a PR if you find time and motivation

[escapedcat]

@honzamelena would you have time to look at the PR as well? lgtm

[honzamelena]

@escapedcat yes, added a comment on the pull request. LGTM

[escapedcat]

Published in v16.0.3. Please give it a try and close this issue if it works, thanks