Skip to content

docs(config.md): list settings first and add missing param #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

woile
Copy link
Member

@woile woile commented Nov 28, 2022

Description

Missing param in settings.
I've also moved the settings at the top. As this is something you may check often, while creating the file is done once at the beginning of the cz configuration.

Checklist

  • Add test cases to all the changes you introduce
  • Run ./scripts/format and ./scripts/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes

@Lee-W Lee-W self-requested a review November 28, 2022 13:35
@woile woile force-pushed the docs/major-version branch from c51662f to 4a93583 Compare November 29, 2022 05:57
@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Base: 97.92% // Head: 97.92% // No change to project coverage 👍

Coverage data is based on head (4a93583) compared to base (db42a95).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #624   +/-   ##
=======================================
  Coverage   97.92%   97.92%           
=======================================
  Files          35       35           
  Lines        1252     1252           
=======================================
  Hits         1226     1226           
  Misses         26       26           
Flag Coverage Δ
unittests 97.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@woile woile merged commit 33d401f into master Nov 29, 2022
@woile woile deleted the docs/major-version branch November 29, 2022 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants