Skip to content

docs: add Why not CalVer to FAQ #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 18, 2022

Conversation

KyleKing
Copy link
Contributor

Addresses: #173

Add explanation for why the issue and PR for CalVer were closed

Please feel free to add comments or edit directly! I would be happy to make this more clear

@KyleKing KyleKing force-pushed the issue-173-faq-update branch from 8497925 to 9f0e326 Compare January 17, 2022 17:40
@codecov
Copy link

codecov bot commented Jan 17, 2022

Codecov Report

Merging #476 (71d2d58) into master (834159d) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #476   +/-   ##
=======================================
  Coverage   98.04%   98.04%           
=======================================
  Files          39       39           
  Lines        1431     1431           
=======================================
  Hits         1403     1403           
  Misses         28       28           
Flag Coverage Δ
unittests 98.04% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
commitizen/__version__.py 100.00% <100.00%> (ø)
commitizen/commands/bump.py 95.19% <100.00%> (ø)
commitizen/exceptions.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e243d4...71d2d58. Read the comment docs.

Copy link
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for updating the docs 🎉 @woile Let's know if you'd like to add more content. If no further comments, I'd like to merge it tomorrow

@woile woile merged commit 8062105 into commitizen-tools:master Jan 18, 2022
@KyleKing KyleKing deleted the issue-173-faq-update branch January 26, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants