Add yaml support for config #315
Conversation
Codecov Report
@@ Coverage Diff @@
## master #315 +/- ##
==========================================
+ Coverage 96.97% 97.17% +0.19%
==========================================
Files 33 35 +2
Lines 926 991 +65
==========================================
+ Hits 898 963 +65
Misses 28 28
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Mmmm I'm not a big fan of |
|
Hi @woile. I'm adding this, because my team (golang developers) ask edfor this. As Go developers we are more familiar with |
I'm neutral to this. I did not use YAML that much. But one of my friends (Golang developer as well haha) did ask me whether we'll have YAML support. |
|
Nice, okay then there's at least some demand. Thanks for the contribution 🎉 |
|
@woile sure, I can do that. |
314 feat(config): add support for the new class YAMLConfig at the root of the confi internal package 314 test(test_config): add test support for the class YAMLConfig 314 fix(YAMLConfig): add a TypeError exception to handle in _parse_settings method feat(init): add support for yaml config file at init 314 test(tests): add test functions to test YAMLConfig class at init and customization 314 docs(docs): add instructions on how to define yaml config files 314
danvergara
force-pushed
the
add-yaml-support-for-config
branch
from
1e1405a to
c09f377
Compare
Description
As mentioned in #314 , this PR add yaml support for configuration
Checklist
./script/formatand./script/testlocally to ensure this change passes linter check and testExpected behavior
Replace a TOML config file with a YAML config file with no side effects, (of course, passing the same arguments).
Steps to Test This Pull Request
Additional context
Related to #314