Skip to content

fix(git): fix returned value for GitCommit.message when body is empty #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 22, 2020

Conversation

vBLFTePebWNi6c
Copy link
Contributor

GitCommit.message should return only title without excess newlines if commit body is empty.

@codecov
Copy link

codecov bot commented Apr 22, 2020

Codecov Report

Merging #166 into master will increase coverage by 0.31%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #166      +/-   ##
==========================================
+ Coverage   91.53%   91.84%   +0.31%     
==========================================
  Files          33       33              
  Lines         768      785      +17     
==========================================
+ Hits          703      721      +18     
+ Misses         65       64       -1     
Flag Coverage Δ
#unittests 91.84% <100.00%> (+0.31%) ⬆️
Impacted Files Coverage Δ
commitizen/git.py 95.00% <100.00%> (ø)
commitizen/config/__init__.py 81.81% <0.00%> (-0.80%) ⬇️
commitizen/cz/customize/customize.py 84.78% <0.00%> (-0.22%) ⬇️
commitizen/cz/base.py 100.00% <0.00%> (ø)
commitizen/defaults.py 100.00% <0.00%> (ø)
commitizen/cz/__init__.py 100.00% <0.00%> (ø)
commitizen/error_codes.py 100.00% <0.00%> (ø)
commitizen/cz/jira/jira.py 100.00% <0.00%> (ø)
...en/cz/conventional_commits/conventional_commits.py 100.00% <0.00%> (ø)
commitizen/config/base_config.py 91.66% <0.00%> (+0.36%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbafb75...f21693e. Read the comment docs.

Copy link
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing 🎉

Copy link
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Let's merge it 👍

@Lee-W Lee-W merged commit 008a8c6 into commitizen-tools:master Apr 22, 2020
@woile
Copy link
Member

woile commented Apr 22, 2020

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants