-
-
Notifications
You must be signed in to change notification settings - Fork 281
docs(taplo): add toml formatter #1456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
docs(taplo): add toml formatter #1456
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1456 +/- ##
==========================================
+ Coverage 97.33% 97.62% +0.28%
==========================================
Files 42 57 +15
Lines 2104 2653 +549
==========================================
+ Hits 2048 2590 +542
- Misses 56 63 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
"cover", | ||
"check-commit", | ||
] | ||
all.sequence = ["format", "lint", "cover", "check-commit"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean this one? But it seems to be a one-liner still
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't find a good combination of options to keep the file unchanged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I set array_auto_collapse = false
then someone with their formatter can still make it a one-liner.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I set column_width = n
for some n < 80
then taplo
introduces more changes.
2f37245
to
261a106
Compare
261a106
to
2d56a80
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm okay with this one, but I will let @woile or @noirbizarre decide whether we need it.
Description
I noticed that I accidentally introduced unexpected style change in
pyproject.toml
(50fd65f), so I think it would be better if we have a consistenttoml
formatter.Checklist
Code Changes
Expected Behavior
Pre-commit hook now has
taplo
and it should work even without installingtaplo
locally.Steps to Test This Pull Request
pyproject.toml
and save without formatting to make the formatting bad.git commit
Additional Context
https://taplo.tamasfe.dev/configuration/formatter-options.html