-
-
Notifications
You must be signed in to change notification settings - Fork 281
fix(defaults): add non-capitalized default constants back and deprecated warning #1447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1447 +/- ##
==========================================
+ Coverage 97.33% 97.63% +0.29%
==========================================
Files 42 57 +15
Lines 2104 2661 +557
==========================================
+ Hits 2048 2598 +550
- Misses 56 63 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This PR won't close #1446. That one is more like a discussion on how we decide to bump a major verison or not (e.g., some private method can be changed whatever we want, while public ones we might not want it to be that way), Thus changed the description to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one nits. over all looks good!
9c8e840
to
80a10e5
Compare
80a10e5
to
a1c3881
Compare
relates: #1446
Description
Related commit: 94c02b3#diff-c951de16d627d82e01eb3ce8d7c4f0b28973ffe147520620762e7140ede2dd80
Checklist
Code Changes
poetry all
locally to ensure this change passes linter check and testsDocumentation Changes
poetry doc
locally to ensure the documentation pages renders correctlyExpected Behavior
Steps to Test This Pull Request
Additional Context