Skip to content

pre-commit hook fails on feat! (doesn't allow exclamation point) #283

Closed
@evanstoddard23

Description

@evanstoddard23

Description

Commits like feat!: describing my breaking change fail at the pre-commit hook

Steps to reproduce

  1. Make a breaking change
  2. Include the pre-commit hook from the readme in your pre-commit-config.yaml file and install hooks
  3. Try to commit with a message like feat!: breaking change

Current behavior

commitizen check.........................................................Failed
- hook id: commitizen
- exit code: 14

commit validation: failed!
please enter a commit message in the commitizen format.
commit "": "feat!: breaking change"
pattern: (build|ci|docs|feat|fix|perf|refactor|style|test|chore|revert|bump)(\(\S+\))?:(\s.*)

Desired behavior

Check should pass according to https://www.conventionalcommits.org/en/v1.0.0/ rules

Environment

  • commitizen version: 2.4.1
  • python version: 2.7.16
  • operating system: Darwin

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions