Change slugs to ascii only #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some tools like the AWS CLI don't do well with unicode file names even though AWS S3 does not have a problem with them. It is saver to use ASCII characters only. Which is the default for Django's builtin slugify method anyways.
Codecov Report
@@ Coverage Diff @@
## master #5 +/- ##
==========================================
+ Coverage 98.27% 98.36% +0.08%
==========================================
Files 1 1
Lines 58 61 +3
==========================================
+ Hits 57 60 +3
Misses 1 1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tools like the AWS CLI don't do well with unicode file names
even though AWS S3 does not have a problem with them. It is saver
to use ASCII characters only. Which is the default for Django's
builtin slugify method anyways.