Skip to content

change eligibilty criteriafor excellence certificate #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 28, 2020
Merged

change eligibilty criteriafor excellence certificate #614

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ec8eb0f
change eligibilty criteriafor excellence certificate
1arp Sep 24, 2020
0060593
Update component.js
abhishek97 Sep 28, 2020
149b61c
Update component.js
abhishek97 Sep 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/pods/components/certificate-comp/excellence-certificate-modal/component.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export default class ExcellenceCertificateModal extends Component {

@computed('stats')
get isQualifiedForExcellenceCertififcate() {
return this.courseCompleted && (this.stats.performance.percentile > this.run.get('excellenceThreshold'))
return this.courseCompleted && (this.stats.performance.scoreCompletionPercentage >= this.run.get('excellenceThreshold'))
}

@dropTask excellenceCertificateTask = function* () {
Expand All @@ -35,4 +35,4 @@ export default class ExcellenceCertificateModal extends Component {
window.open(this.excellenceCertificate.url, '_blank')
}

};
};
4 changes: 2 additions & 2 deletions app/pods/components/certificate-comp/excellence-certificate-modal/template.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@
</p>

<p class="font-sm">
Complete {{run.completionThreshold}}% of the course and be in the top {{run.excellenceThreshold}}
percentile to generate excellence certificate.</p>
Complete {{run.completionThreshold}}% of the course and score {{run.excellenceThreshold}}%
of the total score to generate excellence certificate.</p>
</div>

{{#if canDownload}}
Expand Down