-
Notifications
You must be signed in to change notification settings - Fork 313
CI: Migrate from Travis to GitHub Actions #429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The codecov bot hasn't made a comment. |
Codecov Report
@@ Coverage Diff @@
## master #429 +/- ##
=============================================
+ Coverage 98.573% 98.629% +0.055%
=============================================
Files 29 29
Lines 3646 3649 +3
=============================================
+ Hits 3594 3599 +5
+ Misses 52 50 -2
|
@czgdp1807 The Windows and macOS tests were failing because of an action that I was using to build docs that was only compatible with Linux. The CI should work fine now. |
@czgdp1807 It works 😄 |
Yeah. Great work. Is there anything we can do to add a timeout using secrets? Let me know if I need to set an environment variable in my Github account. |
Hi @czgdp1807 I have added a timeout secret. To set up a secret, go to your Repository Settings page, then select Secrets. You can add a secret named You can kick-start the CI once again and we will see if its working as per our expectations :) |
Tests don't seem to start. I have added the secret though. |
The error,
|
@czgdp1807 Seems like we cannot add a secret as a job value. We have to define it manually here. |
Okay. Lets do that for now. |
Hi @czgdp1807 Apologies for the delay. I have set the timeout minutes. Let me know if you wish to have further changes or need the commits to be squashed before merging. Thanks! |
Thanks @HarshCasper for this. |
The badge in the README needs to be updated though. As of now it uses to Travis CI for showing, |
I will make a follow-up PR for that. Should I also add Flake8 and format code using Black? It would be a comparatively larger PR and I would like to know if you would be okay with that? |
N.B. - #324 (comment) |
Description
This PR:
.travis.yml
3.7
,3.8
,3.9
,3.10