Skip to content

Fix Laravel 9 test runner #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

JamesFreeman
Copy link
Contributor

@JamesFreeman JamesFreeman commented Mar 3, 2022

I've got the test runner to work against Laravel 9 now I have made the following changes:

  • Updated composer to allow 9.x packages
  • Updated validated to match 9.x signature
  • Reverted some typed elements as it was breaking the tests.

I do think looking at your PR it might be worth reverting all parameter/return types changes, especially in the contracts as this would be a breaking change.

Looks like I don't have access to run the tests against this repo, Here is mine: https://github.com/JamesFreeman/laravel-totem/runs/5403882721?check_suite_focus=true

@qschmick
Copy link
Collaborator

qschmick commented Mar 7, 2022

@JamesFreeman Thank you for the help, really appreciate it. I was planning on this being a new major release and there is a chance for BC as we're bumping the minimum PHP version and targeting a new major release of the framework.

@JamesFreeman
Copy link
Contributor Author

Ah, that makes sense. Feel free to revert my type changes, I had to make them to get the tests to pass :)

@JamesFreeman
Copy link
Contributor Author

Closed as merged in by @albanh and #327

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants