Skip to content

Fix N+1 frequencies relation at tasks dashboard #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 24, 2022
Merged

Fix N+1 frequencies relation at tasks dashboard #315

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8976719
fixbug issue 309
locnguyen1842 Feb 23, 2022
8b3d3a3
styleci fix
locnguyen1842 Feb 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/Http/Controllers/TasksController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ class TasksController extends Controller
/**
* TasksController constructor.
*
* @param TaskInterface $tasks
* @param TaskInterface $tasks
*/
public function __construct(TaskInterface $tasks)
{
Expand All @@ -45,6 +45,7 @@ public function index()
->when(request('q'), function (Builder $query) {
$query->where('description', 'LIKE', '%'.request('q').'%');
})
->with('frequencies')
->paginate(20),
]);
}
Expand All @@ -71,7 +72,7 @@ public function create()
/**
* Store a newly created task in storage.
*
* @param TaskRequest $request
* @param TaskRequest $request
* @return \Illuminate\Http\RedirectResponse
*/
public function store(TaskRequest $request)
Expand Down Expand Up @@ -119,7 +120,7 @@ public function edit(Task $task)
/**
* Update the specified task in storage.
*
* @param TaskRequest $request
* @param TaskRequest $request
* @param $task
* @return \Illuminate\Http\RedirectResponse
*/
Expand Down