Skip to content

Fix pipeline of Heroku Review Apps #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 29, 2020
Merged

Conversation

yasulab
Copy link
Member

@yasulab yasulab commented Jul 29, 2020

Heroku Review Apps are upgraded and need to follow the change.

The new version of review apps does not support parent apps -
inherited configuration is specified in app.json or
in the Pipeline’s configuration variables.

cf. Review Apps (New) - Heroku Dev Center

cf. #907 (comment)

yasulab added 2 commits July 29, 2020 21:27
> The new version of review apps does not support parent apps -
> inherited configuration is specified in app.json or
> in the Pipeline’s configuration variables.

cf. Review Apps (New) - Heroku Dev Center
https://devcenter.heroku.com/articles/github-integration-review-apps#feature-changes
@yasulab yasulab added the 急ぎじゃないよ Make something better but not rushed. label Jul 29, 2020
@yasulab yasulab self-assigned this Jul 29, 2020
@yasulab yasulab force-pushed the fix-heroku-review-apps-pipeline branch from 9c81c2a to d175084 Compare July 29, 2020 12:39
@yasulab yasulab temporarily deployed to coderdojo-pi-fix-heroku-wmr476 July 29, 2020 12:39 Inactive
@yasulab yasulab changed the title Fix heroku review apps pipeline Fix pipeline of Heroku Review Apps Jul 29, 2020
@yasulab
Copy link
Member Author

yasulab commented Jul 29, 2020

お、動いた!これで一旦マージしますね 🛠💨✨

image

@yasulab yasulab merged commit 7b3a1a6 into master Jul 29, 2020
@yasulab yasulab deleted the fix-heroku-review-apps-pipeline branch July 29, 2020 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
急ぎじゃないよ Make something better but not rushed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant