Upgrade Rails: 5.1.7 -> 5.2.4.1 #704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yuppymam
force-pushed
the
Upgrade_to_rails5.2
branch
from
15dd025 to
be6ed2a
Compare
|
@chicaco こちらよければレビューしてもらえると助かります...!! (＞人＜ )✨ |
chicaco
reviewed
Jan 19, 2020
|
@chicaco 私の環境では、Kata, 公式ブックも動作確認済みなのですが、chicaco さんの手元ではエラーが起きている状態ですか？それとも環境設定していないという感じでしょうか？💦 |
|
お、もしかしてこちらマージすると /kata が落ちる可能性がある...? 👀 💭 |
環境設定していない状況です。済みません！ 🙇♀ |
This was referenced Feb 3, 2020
|
CI 通ったのでマージします！😆💖 |
9 tasks
|
おぉ〜〜〜😆🎉✨ご確認＆マージありがとうございます😆🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #364
アップグレード前に通らなかったテストはデプロイ時にスキップされていそうなので、対応していません🙇♀️
やったこと
Rails5.2 へアップグレード
bootsnap gem の追加(Rails5.2 へアップグレードに伴う)
scrivito gem 1.16 へ変更
アップグレード後も上記テスト以外が通ることを確認
正常に http://localhost:3000/ で表示&画面推移できることを確認
@yasulab お手隙の際にご確認よろしくお願いします📄✨