Set AUTH for Staging apps in Heroku Review #409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AnaTofuZ もしよかったらこの Heroku Review Apps + Auth 対応の PR をお願いできると嬉しいです... (＞人＜;)💦 |
|
@yasulab このタスクでうまく行ってないのってHeroku側で症状が出てる感じですか? |
@AnaTofuZ ですね! と言いつつちょっと古いので記憶が曖昧で恐縮ですが、ローカル環境ではうまく動いていたかなと記憶しています! 💭 ✅ |
|
heroku側を見に行ってみます 👀 |
なるほど! ローカルと何か差分が発生していそうな気配を感じているので、色々見てみます! |
|
(＞人＜ )✨(＞人＜ )✨(＞人＜ )✨ |
|
やること
|
ログの一部
```
2019-05-13T08:35:34.525200+00:00 app[web.1]: I, [2019-05-13T17:28:05.561430 #4] INFO -- : [41bf0d29-96b2-47b7-8c99-60a1d605c831] Started GET "/" for 133.13.48.132 at 2019-05-13 17:28:05 +0900
2019-05-13T08:35:34.525201+00:00 app[web.1]: I, [2019-05-13T17:28:05.562646 #4] INFO -- : [41bf0d29-96b2-47b7-8c99-60a1d605c831] Processing by HomeController#show as HTML
2019-05-13T08:35:34.525204+00:00 app[web.1]: I, [2019-05-13T17:28:05.665825 #4] INFO -- : [41bf0d29-96b2-47b7-8c99-60a1d605c831] Completed 500 Internal Server Error in 103ms (ActiveRecord: 72.0ms | Scrivito: 0.0ms)
2019-05-13T08:35:34.525206+00:00 app[web.1]: F, [2019-05-13T17:28:05.666414 #4] FATAL -- : [41bf0d29-96b2-47b7-8c99-60a1d605c831]
2019-05-13T08:35:34.525207+00:00 app[web.1]: F, [2019-05-13T17:28:05.666463 #4] FATAL -- : [41bf0d29-96b2-47b7-8c99-60a1d605c831] ActiveRecord::StatementInvalid (PG::UndefinedTable: ERROR: relation "dojos" does not exist
2019-05-13T08:35:34.525208+00:00 app[web.1]: LINE 8: WHERE a.attrelid = '"dojos"'::regclass
2019-05-13T08:35:34.525210+00:00 app[web.1]: ^
2019-05-13T08:35:34.525211+00:00 app[web.1]: : SELECT a.attname, format_type(a.atttypid, a.atttypmod),
2019-05-13T08:35:34.525212+00:00 app[web.1]: pg_get_expr(d.adbin, d.adrelid), a.attnotnull, a.atttypid, a.atttypmod,
2019-05-13T08:35:34.525213+00:00 app[web.1]: c.collname, col_description(a.attrelid, a.attnum) AS comment
2019-05-13T08:35:34.525214+00:00 app[web.1]: FROM pg_attribute a
2019-05-13T08:35:34.525216+00:00 app[web.1]: LEFT JOIN pg_attrdef d ON a.attrelid = d.adrelid AND a.attnum = d.adnum
2019-05-13T08:35:34.525217+00:00 app[web.1]: LEFT JOIN pg_type t ON a.atttypid = t.oid
2019-05-13T08:35:34.525218+00:00 app[web.1]: LEFT JOIN pg_collation c ON a.attcollation = c.oid AND a.attcollation <> t.typcollation
2019-05-13T08:35:34.525219+00:00 app[web.1]: WHERE a.attrelid = '"dojos"'::regclass
2019-05-13T08:35:34.525221+00:00 app[web.1]: AND a.attnum > 0 AND NOT a.attisdropped
2019-05-13T08:35:34.525222+00:00 app[web.1]: ORDER BY a.attnum
2019-05-13T08:35:34.525223+00:00 app[web.1]: ):
2019-05-13T08:35:34.525224+00:00 app[web.1]: F, [2019-05-13T17:28:05.666494 #4] FATAL -- : [41bf0d29-96b2-47b7-8c99-60a1d605c831]
2019-05-13T08:35:34.525225+00:00 app[web.1]: F, [2019-05-13T17:28:05.666533 #4] FATAL -- : [41bf0d29-96b2-47b7-8c99-60a1d605c831] app/models/dojo.rb:14:in `block in '
2019-05-13T08:35:34.525226+00:00 app[web.1]: [41bf0d29-96b2-47b7-8c99-60a1d605c831] app/models/dojo.rb:35:in `active_dojos_count'
2019-05-13T08:35:34.525227+00:00 app[web.1]: [41bf0d29-96b2-47b7-8c99-60a1d605c831] app/controllers/home_controller.rb:3:in `show'
2019-05-13T08:35:34.525229+00:00 app[web.1]: I, [2019-05-13T17:28:10.352810 #4] INFO -- : [47e0f4c4-f441-4562-a633-81d8fa1931e2] Started GET "/" for 133.13.48.132 at 2019-05-13 17:28:10 +0900
2019-05-13T08:35:34.525230+00:00 app[web.1]: I, [2019-05-13T17:28:10.354031 #4] INFO -- : [47e0f4c4-f441-4562-a633-81d8fa1931e2] Processing by HomeController#show as HTML
2019-05-13T08:35:34.525231+00:00 app[web.1]: I, [2019-05-13T17:28:10.357586 #4] INFO -- : [47e0f4c4-f441-4562-a633-81d8fa1931e2] Completed 500 Internal Server Error in 3ms (ActiveRecord: 1.6ms | Scrivito: 0.0ms)
2019-05-13T08:35:34.525232+00:00 app[web.1]: F, [2019-05-13T17:28:10.358121 #4] FATAL -- : [47e0f4c4-f441-4562-a633-81d8fa1931e2]
2019-05-13T08:35:34.525233+00:00 app[web.1]: F, [2019-05-13T17:28:10.358160 #4] FATAL -- : [47e0f4c4-f441-4562-a633-81d8fa1931e2] ActiveRecord::StatementInvalid (PG::UndefinedTable: ERROR: relation "dojos" does not exist
2019-05-13T08:35:34.525241+00:00 app[web.1]: LINE 8: WHERE a.attrelid = '"dojos"'::regclass
2019-05-13T08:35:34.525242+00:00 app[web.1]: ^
2019-05-13T08:35:34.525244+00:00 app[web.1]: : SELECT a.attname, format_type(a.atttypid, a.atttypmod),
2019-05-13T08:35:34.525245+00:00 app[web.1]: pg_get_expr(d.adbin, d.adrelid), a.attnotnull, a.atttypid, a.atttypmod,
2019-05-13T08:35:34.525246+00:00 app[web.1]: c.collname, col_description(a.attrelid, a.attnum) AS comment
2019-05-13T08:35:34.525247+00:00 app[web.1]: FROM pg_attribute a
2019-05-13T08:35:34.525248+00:00 app[web.1]: LEFT JOIN pg_attrdef d ON a.attrelid = d.adrelid AND a.attnum = d.adnum
2019-05-13T08:35:34.525249+00:00 app[web.1]: LEFT JOIN pg_type t ON a.atttypid = t.oid
2019-05-13T08:35:34.525250+00:00 app[web.1]: LEFT JOIN pg_collation c ON a.attcollation = c.oid AND a.attcollation <> t.typcollation
2019-05-13T08:35:34.525251+00:00 app[web.1]: WHERE a.attrelid = '"dojos"'::regclass
2019-05-13T08:35:34.525252+00:00 app[web.1]: AND a.attnum > 0 AND NOT a.attisdropped
2019-05-13T08:35:34.525253+00:00 app[web.1]: ORDER BY a.attnum
2019-05-13T08:35:34.525254+00:00 app[web.1]: ):
2019-05-13T08:35:34.525255+00:00 app[web.1]: F, [2019-05-13T17:28:10.358198 #4] FATAL -- : [47e0f4c4-f441-4562-a633-81d8fa1931e2]
2019-05-13T08:35:34.525257+00:00 app[web.1]: F, [2019-05-13T17:28:10.358228 #4] FATAL -- : [47e0f4c4-f441-4562-a633-81d8fa1931e2] app/models/dojo.rb:14:in `block in '
2019-05-13T08:35:34.525258+00:00 app[web.1]: [47e0f4c4-f441-4562-a633-81d8fa1931e2] app/models/dojo.rb:35:in `active_dojos_count'
2019-05-13T08:35:34.525259+00:00 app[web.1]: [47e0f4c4-f441-4562-a633-81d8fa1931e2] app/controllers/home_controller.rb:3:in `show'
2019-05-13T08:35:34.525260+00:00 app[we
```
ログを見た感じ、「Authのエラーではなくて、ReviewApps作成時にDBにseedが設定されておらず、 |
なるほどあり得る...!?!? 🙈💦 |
|
確かDBのセットアップに関しては Line 31 in c7c1c4a HerokuReviewAppの作成時をトリガーにして、特定の処理を走らせるみたいな機能があれば解決しそうです。もしくは既にあるDBにアクセスするようにしてしまう...?(そんな事が可能?) |
|
もしくはDBにアクセスした際に、なかったら例外受け取って回避するみたいな機構を実装する世界かな･･･ :thinking_face: |
|
ログみた感じSELECT文で死んでそうなので このあたりで死んでいそうな気がする･･･ |
|
Heroku Review Apps 作成時に Seed を流すようにするといいのかなー🤔💭 |
|
それかDBコピってくる運用かな･･･と思って雑に検索してみました。 DBをコピーしてくる方法がstackoverflowで見つかったので、これ使うかな･･･と思っています |
|
🆒d(￣ ￣)✨ |
|
stack overflowの上の記事を見ると といかにも |
|
ドキュメントを見た感じ
ということがわかったので、jsonを編集してえいやっとします |
#369 の際に、review appsの作成時にアクセスできない状況が発生した。 review appsでアプリを作成した際に、DBの初期設定を行っていなかったのが原因と思うので app.jsonに初期設定のコマンドを追加した cf. https://devcenter.heroku.com/articles/app-json-schema#scripts
|
scriptsにコマンドをガッと書いてcommit pushしたので、うまくログインできればOKかな･･･ |
|
build log見た感じ使われている気配がない...! 😢 |
|
@AnaTofuZ 試しに Merge しちゃってもいいです Yo...!! 👍 ✨ (もし不具合が起きたら rollback して Rollback 王を狙いましょう 🤣) cf. サーバーが落ちてもすぐ復帰！ロールバック方法を押さえよう - Qiita:Team |
|
ありがとうございます!! 「Rollback 王に俺はなる!!!!」 |
|
一旦これで検証用PRか、今のPRでステージングを再構築する形で確認してみます |
🤣🆒✨ |
This was referenced May 14, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heroku Review Apps がうまく動くか試してみます 🔧 💨
Fix #369: Heroku Review Apps を coderdojo.jp でも使いたい