Skip to content

Temporary fix 2nd sort key of Dojo.default_order #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 26, 2017
Merged

Temporary fix 2nd sort key of Dojo.default_order #220

merged 1 commit into from
Nov 26, 2017

Conversation

nalabjp
Copy link
Member

@nalabjp nalabjp commented Nov 26, 2017

#201 (comment)

Dojoの並び順が意図していない順に並んでいたので一時的にDojo.orderを使ってソートしておく。

ref: #58 #219

@yasulab
Copy link
Member

yasulab commented Nov 26, 2017 •
edited
Loading

ありがとうございます! マージしますね ;)

ちなみに id -> order に変更すると、 #217 で参照している #215 を re-open した方が良いですかね? 🤔

@yasulab yasulab merged commit f95499d into master Nov 26, 2017
@yasulab yasulab deleted the 2nd-sort-key branch November 26, 2017 15:35
@nalabjp
Copy link
Member Author

nalabjp commented Nov 26, 2017

id -> order に変更すると、 #217 で参照している #215 を re-open した方が良いですかね? 🤔

いえ、大丈夫です！
第二ソートキーがorderで問題ないのを確認しました😌

@yasulab
Copy link
Member

yasulab commented Nov 26, 2017 •
edited
Loading

了解です! 🙆
本番環境でも都道府県 + order でソートされていることを確認しました ✅

https://coderdojo.jp/#dojos
screen shot 2017-11-27 at 0 43 44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nalabjp @yasulab