Skip to content

Use haml-rails and convert erb to haml #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 26, 2017
Merged

Use haml-rails and convert erb to haml #214

merged 5 commits into from
Nov 26, 2017

Conversation

nalabjp
Copy link
Member

@nalabjp nalabjp commented Nov 26, 2017

fix #121

Changes

  • haml-railsを導入した
  • bin/rails haml:erb2hamlでerbをhamlに変換した

@nalabjp nalabjp force-pushed the use-haml branch 2 times, most recently from 1a0f0e9 to 0376357 Compare November 26, 2017 09:55
@nalabjp nalabjp changed the title [WIP] Use haml-rails and convert erb to haml Use haml-rails and convert erb to haml Nov 26, 2017
@nalabjp
Copy link
Member Author

nalabjp commented Nov 26, 2017

ざっくりTop, kata, docsあたりを確認してそれなりにページが出ているのを確認しました。
新旧じっくり比べると 6fc827b のような修正も見つかったりするのですが、
これで解消したのが半角スペースを一つ削除するだけ、というあまりコスパが良くない感じなので、
勢いで移行してみても良いかなと思いましたがどうでしょうか?🤔

@yasulab
Copy link
Member

yasulab commented Nov 26, 2017

おー、erm -> haml への移行ありがとうございます! だんだん Rails アプリケーションっぽい感じになってきましたね😸 勢いで移行しちゃいましょう 🏃💨

@yasulab yasulab merged commit b84dd01 into master Nov 26, 2017
@yasulab yasulab deleted the use-haml branch November 26, 2017 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Haml (version 5+) を使いたひ
2 participants