Skip to content

[Don't merge] CI check #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 31 commits into from
Closed

[Don't merge] CI check #210

wants to merge 31 commits into from

Conversation

nalabjp
Copy link
Member

@nalabjp nalabjp commented Nov 25, 2017

for #209

@nalabjp
Copy link
Member Author

nalabjp commented Nov 25, 2017

#209 (comment)
を解消するためにempty commitを先頭に突っ込んでみたがどうだろう?

@nalabjp
Copy link
Member Author

nalabjp commented Nov 25, 2017

1) Sotechshas Quizzes should be permalink Quizzes should be permalink
     Failure/Error: LoginPage.create(title: 'ログイン')
     Scrivito::ClientError:
       Action refused because workspace is read-only.
     # ./app/controllers/cms_controller.rb:4:in `<class:CmsController>'
     # ./app/controllers/cms_controller.rb:1:in `<top (required)>'
     # ./app/controllers/blog_post_page_controller.rb:1:in `<top (required)>'
     # ./spec/requests/sotechshas_spec.rb:8:in `block (4 levels) in <top (required)>'
     # ./spec/requests/sotechshas_spec.rb:7:in `block (3 levels) in <top (required)>'

恐らく、コケるテストは関係なくてLoginPage.createが初めて実行される時にworkspaceがread-onlyになっている模様。
(手元で何回もテストを実行すると、いろんなspecがコケるが必ず1回だけ同様のエラーになる)

@nalabjp
Copy link
Member Author

nalabjp commented Nov 25, 2017

https://scrivito.com/adding-a-log-in-page-to-your-application-71c659702470e21c
を見ると、LoginPage.createScrivito::Workspace.useと同じタイミングで実行しているので、
それにあわせるためにinitializersに移動してみた 57386bb

@nalabjp
Copy link
Member Author

nalabjp commented Nov 25, 2017

こっちは 57386bb で 💚

@nalabjp
Copy link
Member Author

nalabjp commented Nov 25, 2017

9663632 でfix 💚

@nalabjp nalabjp closed this Nov 25, 2017
@nalabjp nalabjp deleted the skip-test branch November 25, 2017 19:59
@nalabjp nalabjp restored the skip-test branch November 25, 2017 20:01
@nalabjp nalabjp reopened this Nov 25, 2017
@nalabjp nalabjp closed this Nov 25, 2017
@nalabjp nalabjp deleted the skip-test branch November 25, 2017 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant