Skip to content

[WIP] Using mock #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions spec/controllers/blog_post_page_controller_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

describe "GET Blog Post Page" do
it "normal blog post" do
obj = Obj.find_by_permalink!("news/2016/12/12/new-backend")
obj = mock_obj(BlogPostPage, permalink: 'news/2016/12/12/new-backend', last_changed: Time.current)
request.for_scrivito_obj(obj)
get :index
expect(assigns(:sts_posts)).to eq nil
Expand All @@ -15,7 +15,7 @@
end

it "sotechsha post" do
obj = Obj.find_by_permalink!("sotechsha/0")
obj = mock_obj(BlogPostPage, permalink: 'sotechsha/0', last_changed: Time.current)
request.for_scrivito_obj(obj)
get :index
sts_posts = BlogPostPage.where(:_permalink, :starts_with, 'sotechsha/').order(created: :asc)
Expand Down
2 changes: 2 additions & 0 deletions spec/controllers/docs_controller_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@
end

it 'when invalid filename' do
obj = mock_obj(PlainPage)
allow(Obj).to receive(:root) { obj }
get :show, params: { id: '../not_found' }
expect(response).to redirect_to controller.scrivito_path(Obj.root)
expect(response.status).to eq 302
Expand Down
26 changes: 26 additions & 0 deletions spec/controllers/sessions_controller_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,32 @@
require 'rails_helper'

RSpec.describe SessionsController, type: :controller do
before(:each) do
obj = mock_obj(PlainPage)
allow(Obj).to receive(:root) { obj }
end

around(:each) do |example|
begin
@old_email = ENV['SCRIVITO_EMAIL'] if ENV.key?('SCRIVITO_EMAIL')
@old_password = ENV['SCRIVITO_PASSWORD'] if ENV.key?('SCRIVITO_PASSWORD')
ENV['SCRIVITO_EMAIL'] = 'dummy@example.com'
ENV['SCRIVITO_PASSWORD'] = 'dummy_password'
example.run
ensure
if @old_email
ENV['SCRIVITO_EMAIL'] = @old_email
else
ENV.delete('SCRIVITO_EMAIL')
end
if @old_password
ENV['SCRIVITO_PASSWORD'] = @old_password
else
ENV.delete('SCRIVITO_PASSWORD')
end
end
end

describe "GET #create" do
it "param match" do
get :create, params: { email: ENV['SCRIVITO_EMAIL'],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

describe "GET #index" do
it "set @sts_post" do
obj = Obj.find_by_permalink!("sotechsha")
obj = mock_obj(PlainPage, permalink: 'sotechsha', last_changed: Time.current)
request.for_scrivito_obj(obj)
get :index
sts_posts = BlogPostPage.where(:_permalink, :starts_with, 'sotechsha/').order(created: :asc)
Expand Down
2 changes: 1 addition & 1 deletion spec/features/users_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
require 'rails_helper'
include Scrivito::ControllerHelper

RSpec.feature "Users", type: :feature do
RSpec.xfeature "Users", type: :feature do
subject { page }

describe "log in" do
Expand Down
2 changes: 2 additions & 0 deletions spec/rails_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -54,4 +54,6 @@
config.filter_rails_from_backtrace!
# arbitrary gems may also be filtered via:
# config.filter_gems_from_backtrace("gem name")

config.include ScrivitoMockHelpers
end
2 changes: 2 additions & 0 deletions spec/requests/news_pages_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
RSpec.describe "NewsPages", type: :request do
describe "GET /news/2016/12/12/new-backend" do
it "Blog post should be rendered" do
obj = mock_obj(Obj, permalink: "/news/2016/12/12/new-backend")
allow(Scrivito::BasicObj).to receive(:find_by_permalink).with("news/2016/12/12/new-backend") { obj }
get '/news/2016/12/12/new-backend'
expect(response).to have_http_status(200)
end
Expand Down
4 changes: 4 additions & 0 deletions spec/requests/sotechshas_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
describe "Quizzes should be permalink" do
it "Quizzes should be permalink" do
(0..6).each do |num|
obj = mock_obj(Obj, permalink: "/sotechsha/#{num}")
allow(Scrivito::BasicObj).to receive(:find_by_permalink).with("sotechsha/#{num}") { obj }
get "/sotechsha/#{num}"
expect(response).to have_http_status(200)
end
Expand All @@ -13,6 +15,8 @@

describe "GET /sotechsha/gazou" do
it "Gazoulink should be permalink" do
obj = mock_obj(Obj, permalink: "/sotechsha/gazou")
allow(Scrivito::BasicObj).to receive(:find_by_permalink).with("sotechsha/gazou") { obj }
get "/sotechsha/gazou"
expect(response).to have_http_status(200)
end
Expand Down
21 changes: 21 additions & 0 deletions spec/support/scrivito_mock_helper.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
module ScrivitoMockHelpers
def mock_obj(klass, attributes={})
obj = klass.new

attributes.each do |name, value|
allow(obj).to receive(name) { value }
end

obj
end

def mock_widget(klass, attributes={})
widget = klass.new

attributes.each do |name, value|
allow(widget).to receive(name) { value }
end

widget
end
end