/sotechsha2 に関連するページを Static にホストするようにしたい #1505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
本PRのURLの方が正しく思いますが、元に揃えた方が良いのかが気になりました🙏 |
Yuppymam
approved these changes
Feb 27, 2023
rakuda-san-desu
approved these changes
Feb 27, 2023
@Yuppymam こちら本番環境の URL 間違っていそうです！こちらの PR で修正されます！ 確認ありがとうございます。 |
|
レビューありがとうございます！マージします ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
やりたいこと
#736 Rails のバージョンを 6.x に上げたいが、Scrivito が 6.x 系に対応していないので、Scrivito でホストしているページを直接アプリ側でホストするように変更して、最終的には Rails 6.x 系に上げたい。
この PR では
/sotechsha2とsotechsha2/:pagesを対象にStaticページを用意しました。やらないと
Scrivito の関連したページの削除や Scrivitio の削除
確認方法
https://coderdojo.jp/sotechsha のページと localhost:3000/sotechsha のページを比較して問題がないか確認してほしいです。