Skip to content

Feature/macos support #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

abhirajbhattashali
Copy link

Added macOS Support with Improved Build System

Changes Made

  • Added conditional CMake configuration for macOS using Homebrew paths
  • Updated build system selection to show all available CMake generators
  • Improved bootstrap script to match Windows functionality while adding macOS support
  • Added proper library linking for both platforms (Windows and macOS)

Key Features

  • Conditional CMake Configuration:

    • Added if(APPLE) blocks to handle macOS-specific paths and configurations
    • Preserved existing Windows configuration
    • Set up proper paths for Armadillo, OpenBLAS, and Eigen on macOS
  • Enhanced Build System Selection:

    • Shows all available CMake generators using cmake --help
    • Allows users to select any available generator
    • Maintains compatibility with both Windows and macOS build systems
  • Improved Bootstrap Script:

    • Updated to handle platform-specific build tools
    • Added proper error handling for missing dependencies
    • Improved user interaction and feedback

Testing

  • Successfully tested on macOS with:
    • Xcode generator
    • Ninja generator
    • Unix Makefiles generator
  • Verified matrix operations working correctly
  • Confirmed build process works on both platforms

Dependencies

Required on macOS:

  • CMake
  • Armadillo
  • OpenBLAS
  • Eigen
  • Xcode or Ninja (optional)

All

@coderboyisongithub coderboyisongithub self-assigned this Mar 28, 2025
@coderboyisongithub
Copy link
Owner

Keep the relevant commit and remove all other commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants