Small refactor #11
Merged
Small refactor #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the Google Cloud logger types as well.
jsjoeio
suggested changes
Apr 26, 2021
| projectId, | ||
| }); | ||
| const log = logging.log(logId) | ||
| const convertSeverity = (severity: Level): gcl.protos.google.logging.type.LogSeverity => { |
There was a problem hiding this comment.
?: why do we do this? Or what is this rather?
There was a problem hiding this comment.
Our logger uses 0-4 to represent trace, debug, info, warn, and error, but Google Cloud uses something like 100, 200, 400, 500 (and has no trace level). So we need to convert the level to the right number.
There was a problem hiding this comment.
I should also note logging to Google Cloud is optional.
|
Uhhh tests are failing in CI, I'll take a look tomorrow. |
|
I was too curious to wait until tomorrow. All fixed up. |
|
Oh huh there were actually existing test files. They just use the logger though and don't actually test anything. 😛 I'll probably just remove them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to add AMD support to experiment with migrating away from Parcel but ended up taking some time to make some improvements. Check out the individual commits for more information (should really be separate PRs probably).