Skip to content

chore: update code to 1.71.2 #5580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 23, 2022
Merged

chore: update code to 1.71.2 #5580

merged 7 commits into from
Sep 23, 2022

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Sep 22, 2022

  • chore: update code to 1.71.2

  • chore: update telemetry patch

  • refactor: drop safari-console patch

  • add aiConfig.ariaKey to build

  • download release and test telemetry

It appears part of the fix has been implemented upstream.
This has been fixed upstream.
@jsjoeio jsjoeio requested a review from a team as a code owner September 22, 2022 19:55
@jsjoeio jsjoeio changed the title jsjoeio/code update chore: update code to 1.71.2 Sep 22, 2022
@jsjoeio jsjoeio self-assigned this Sep 22, 2022
@jsjoeio jsjoeio enabled auto-merge (squash) September 22, 2022 19:56
@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Merging #5580 (1906ab8) into main (fdec34c) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5580   +/-   ##
=======================================
  Coverage   72.44%   72.44%           
=======================================
  Files          30       30           
  Lines        1673     1673           
  Branches      366      366           
=======================================
  Hits         1212     1212           
  Misses        398      398           
  Partials       63       63           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdec34c...1906ab8. Read the comment docs.

@jsjoeio jsjoeio temporarily deployed to npm September 22, 2022 20:08 Inactive
@github-actions
Copy link

github-actions bot commented Sep 22, 2022

✨ code-server dev build published to npm for PR #5580!

  • Last publish status: success
  • Commit: 1906ab8

To install in a local project, run:

npm install @coder/code-server-pr@5580

To install globally, run:

npm install -g @coder/code-server-pr@5580

@jsjoeio jsjoeio temporarily deployed to npm September 22, 2022 22:21 Inactive
@code-asher
Copy link
Member

Neat they made those telemetry changes. Does ours still emit telemetry? I see a productService.aiConfig?.ariaKey in there which looks like it would disable telemetry since we do not set that.

@jsjoeio jsjoeio temporarily deployed to npm September 23, 2022 20:30 Inactive
@jsjoeio jsjoeio temporarily deployed to npm September 23, 2022 22:34 Inactive
@jsjoeio jsjoeio merged commit 3256157 into main Sep 23, 2022
@jsjoeio jsjoeio deleted the jsjoeio/code-update branch September 23, 2022 22:51
@benz0li
Copy link
Contributor

benz0li commented Sep 25, 2022

code-server-4.7.0-linux-amd64.tar.gz of the artifacts is deployed at https://vscode-r.jupyter.b-data.ch; Image R (base:test) + code-server.

Functionality [modified by patches] tested and found to work:

  • base-path
  • cli-window-open
  • local-storage
  • marketplace
  • proxy-url
  • service-worker
  • webview

Jupyter Notebooks also work fine:

  • ms-toolsai.jupyter@2022.8.1002460559
  • ms-python.python@v2022.14.0

@jsjoeio
Copy link
Contributor Author

jsjoeio commented Sep 26, 2022

@benz0li really appreciate you testing and deploying it to test! You rock!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants