refactor: add func and tests for getNlsConfiguration #3640
Merged
+128
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3640 +/- ##
==========================================
+ Coverage 60.67% 61.33% +0.66%
==========================================
Files 35 35
Lines 1790 1800 +10
Branches 404 408 +4
==========================================
+ Hits 1086 1104 +18
+ Misses 562 554 -8
Partials 142 142
Continue to review full report at Codecov.
|
jsjoeio
commented
Jun 18, 2021
| _resolvedLanguagePackCoreLocation?: string | ||
| _corruptedFile?: string | ||
| _languagePackSupport?: boolean | ||
| loadBundle?: any |
There was a problem hiding this comment.
Incremental type improvements 😄
One day, we will be able to remove that /* eslint-disable @typescript-eslint/no-explicit-any */ but today is not that today.
jsjoeio
force-pushed
the
jsjoeio/add-test-nlsConfig
branch
from
9386833 to
d833967
Compare
jsjoeio
commented
Jun 18, 2021
code-asher
reviewed
Jun 21, 2021
code-asher
reviewed
Jun 21, 2021
jsjoeio
force-pushed
the
jsjoeio/add-test-nlsConfig
branch
3 times, most recently
from
2c69ada to
1d19c4c
Compare
|
@code-asher ready for a a second review! |
code-asher
reviewed
Jun 23, 2021
jsjoeio
force-pushed
the
jsjoeio/add-test-nlsConfig
branch
from
1d19c4c to
e6c828b
Compare
code-asher
reviewed
Jun 23, 2021
jsjoeio
force-pushed
the
jsjoeio/add-test-nlsConfig
branch
from
e6c828b to
e0ab67d
Compare
code-asher
approved these changes
Jun 23, 2021
This PR refactors part of vscode.ts and adds a function to get the NLS Configuration. This makes the code more readable and easier to test. And it adds multiple tests for this part of the codebase.
jsjoeio
force-pushed
the
jsjoeio/add-test-nlsConfig
branch
from
e0ab67d to
02b9489
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors a couple lines inside
src/browser/pages/vscode.tsso that it's easier to maintain and test.Changes
getNlsConfigurationChecklist
CHANGELOG.mdFixes: N/A