Skip to content

docs: Update CONTRIBUTING.md #3630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2021
Merged

docs: Update CONTRIBUTING.md #3630

merged 1 commit into from
Jun 17, 2021

Conversation

janiversen
Copy link
Contributor

Node needs be v14.x not greater. If installing the standard version ‘brew install node’, both ‘yarn’ and ‘code-server’ (release version) complains.

Newest version is v16.x so we are pretty far behind.

Checklist

  • updated CHANGELOG.md

@janiversen janiversen requested a review from a team as a code owner June 17, 2021 18:53
Node needs be v14.x not greater. If installing the standard version ‘brew install node’, both ‘yarn’ and ‘code-server’ (release version) complains.

Newest version is v16.x so we are pretty far behind.
@codecov
Copy link

codecov bot commented Jun 17, 2021

Codecov Report

Merging #3630 (ece5de6) into main (bf45e7c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3630   +/-   ##
=======================================
  Coverage   60.67%   60.67%           
=======================================
  Files          35       35           
  Lines        1790     1790           
  Branches      404      404           
=======================================
  Hits         1086     1086           
  Misses        562      562           
  Partials      142      142           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf45e7c...ece5de6. Read the comment docs.

@jsjoeio jsjoeio changed the title Update CONTRIBUTING.md docs: Update CONTRIBUTING.md Jun 17, 2021
@jsjoeio jsjoeio self-assigned this Jun 17, 2021
@jsjoeio jsjoeio added the docs Documentation related label Jun 17, 2021
@jsjoeio jsjoeio added this to the 3.11.0 milestone Jun 17, 2021
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, nice fix!

Yeah I think we're limited by the Node.js version supported for developing VSCode but hoping they catch up soon and then we can catch up.

@jsjoeio jsjoeio merged commit 5f7e9b7 into coder:main Jun 17, 2021
@janiversen janiversen deleted the patch-1 branch June 18, 2021 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants