Unable to build release 4.13

[drupol]

Is there an existing issue for this?

• I have searched the existing issues

OS/Web Information

• Web Browser:
• Local OS: Linux
• Remote OS:
• Remote Architecture:
• code-server --version: 4.13

Steps to Reproduce

I'm trying to update code-server in nix through this PR: NixOS/nixpkgs#234289
Basically we are upgrading from 4.12 to 4.13, and it seems that it's not buildable.

Expected

compilation works

Actual

Logs

https://gist.github.com/drupol/a2c05a189481ff57de6b3624874b960b

Screenshot/Video

No response

Does this issue happen in VS Code or GitHub Codespaces?

• I cannot reproduce this in VS Code.
• I cannot reproduce this in GitHub Codespaces.

Are you accessing code-server over HTTPS?

• I am using HTTPS.

Notes

No response

[code-asher]

Those definitions seem to come from the typescript npm module found in lib/vscode. There is a different version installed in the root, I wonder if the types are somehow resolving up past lib/vscode and using the wrong version although I am not sure why that would happen. Maybe we make it work by updating the version in the root to match what Code is using.

If so, then #6182 might fix it.

[drupol]

Hi!

I have the same issue using commit f6db985 (latest of master branch)

To be honest, I'm running out of ideas here.
I'm trying to propose an update in Nix, without luck, I'm blocked because of this issue.

See relevant thread: NixOS/nixpkgs#234289

[code-asher]

Ah unfortunate. That PR updates to v5 but I suppose one more thing we could try is updating to the exact version VS Code is using (5.1.0-dev.20230424).

I am not confident that will do anything but let me test a bit and see what happens.

By the way, looks like the derivation builds the cloud agent but we took down the cloud service and removed the accompanying flag to enable it a while back so all that could be removed.

[drupol]

By the way, looks like the derivation builds the cloud agent but we took down the cloud service and removed the accompanying flag to enable it a while back so all that could be removed.

Excellent, I just removed it.

Let me know how it goes!

[code-asher]

I think the issue is that one of the postinstall scripts is not being ran, namely ./lib/vscode/extensions/postinstall.mjs, referenced in ./lib/vscode/extensions/package.json. If I run that I get past the type errors, then I get 'commit' is missing from product.json which perhaps implies that git rev-parse HEAD is not returning anything?

code-server/ci/build/build-vscode.sh

Lines 51 to 55 in ccb0d3a

	# Set the commit Code will embed into the product.json. We need to do this
	# since Code tries to get the commit from the `.git` directory which will fail
	# as it is a submodule.
	export BUILD_SOURCEVERSION
	BUILD_SOURCEVERSION=$(git rev-parse HEAD)

[code-asher]

Oh I see git rev-parse HEAD is actually replaced with $commit so I suppose that variable is missing/blank.

[drupol]

Glad you took the time to check it out, it's greatly appreciated.

I'm also glad you found out the root issue, I'm looking forward to the next version and packaging it in Nix.

If you'd like to help me into the maintenance of code-server in Nix, just let me know, I can add you as maintainer.

[code-asher]

If you'd like to help me into the maintenance of code-server in Nix, just let me know, I can add you as maintainer.

Sounds good to me! I would be happy to help out.

[code-asher]

We got this sorted out in NixOS/nixpkgs#237986