[Bug]: bad EXTENSIONS_GALLERY input not handled

[jsjoeio]

Is there an existing issue for this?

• I have searched the existing issues

OS/Web Information

• Web Browser: any
• Local OS: macOS
• Remote OS: macOS
• Remote Architecture: amd64
• code-server --version: 4.5.1

Steps to Reproduce

1. run EXTENSIONS_GALLERY='{"serviceUrl":"undefined"}' code-server --install-extension yolo
2. observe output

Expected

stderr should print No extension gallery service configured or something else.

Actual

stderr prints connect ECONNREFUSED 127.0.0.1:3000

Logs

EXTENSIONS_GALLERY='{"serviceUrl":"undefined"}' code-server --install-extension yolo
Installing extensions...
connect ECONNREFUSED 127.0.0.1:3000

Screenshot/Video

n/a

Does this issue happen in VS Code or GitHub Codespaces?

• I cannot reproduce this in VS Code.
• I cannot reproduce this in GitHub Codespaces.

Are you accessing code-server over HTTPS?

• I am using HTTPS.

Notes

Identified while working on #5432

Talking to @code-asher about this, we have a theory:

• https://github.com/microsoft/vscode/blob/460768a452221ee8595dcc15114b285a09f4f9cf/src/vs/platform/extensionManagement/common/extensionGalleryService.ts#L598
• this ends up being just /path without a domain
• then in the request service it would get defaulted to port 80 and the default hostname is probably localhost so that explains the behavior Asher gets
• still unsure why Joe gets 3000

[code-asher]

So...I do think this would be good to have, and I think maybe I brought it up to begin with, but I am going to close for now since it seems no one has ran into this in the wild, and I suppose if someone sets this to undefined they are kinda asking for problems anyway.