Search in folder stopped working

[elgandoz]

• code-server version: 2.1662-vsc1.39.2
• OS Version: Centos/RHEL 7

Description

Searching a string in files, in a non-ignored folder, doesn't return any result, regardless of settings or type.
It looks somehow a regression from #438.

Reverting to 2.1650-vsc1.39.2, using the exact same configuration, works as expected.
I also tried to remove the configuration (thus starting with a fresh one) to make sure the issue doesn't sit there, but I get the same behavior.

I didn't try on version 2.1655-vsc1.39.2 (yet).

Steps to Reproduce

1. In the file explorer, right click on a folder > Find in Folder...
2. Type a string expected to be found and hit enter
3. The result is empty, even if you extend the search to all files

[code-asher]

Thanks for finding this!

[elgandoz]

Thanks for fixing it!

[roflcoopter]

@code-asher This issue seems to be again present in the latest release.
reverting back to tag 2.1697-vsc1.39.2 makes Find in Folder work again.

[muhammadnscorp]

@code-asher Find in Folder not working in
Version: 1.41.1
Code Server Version: 2.1698-vsc1.41.1

[nhooyr]

Is there an error?

[kylecarbs]

It's working for me on 2.1698-vsc1.41.1.

[muhammadnscorp]

[muhammadnscorp]

Its working on HTTPS but not on HTTP. Dont know if that is an intended behavior, if that is then its working fine.

[kylecarbs]

Did you remove /tmp/code-server?

On launch, code-server unpacks rg into that dir.

[muhammadnscorp]

I tried that and it's working now. thanks @kylecarbs