Skip to content

chore: Update snapshots #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Conversation

varungandhi-src
Copy link

I was unable to push directly to you branch in your PR:
sourcegraph#132

So I've created this PR.

In the future, there should be a setting like 'Allow edits
from maintainers' which you can enable so that I can
push to your PR directly.

It looks like a bug is being introduced where we're
emitting duplicate occurrences for classes. AFAICT,
that's an actual bug in the code emitting occurrences,
not in the code printing snapshot outputs, but you'd
have to check. For example, see this part of the patch:

CleanShot 2023-11-21 at 14 21 31@2x

I recommend merging this PR first, and then fixing that
issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants