-
Notifications
You must be signed in to change notification settings - Fork 10
Fixing issue performance of group and owner file attribute cache which was introduced in 2.6.1 #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Is this fix okay from your point of view? Asking if I should attend fixing the rest of the builds |
@plamentotev @krosenvold what do you think about this? |
Hi, I can take a look latter this week, but in general the changes look ok. |
The question is: why does |
I would say that fetching group name and owner name can be lookup heavy on some systems with some security related to mapping group and owner name to gid/uid. This causes the issue together with the 2.6.1 that unintentionally disabled this naming lookup caching. |
LGTM maybe you can write some jmh tests to compare. I'm happy to run them on a beefy machine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added some small comments. Also if you can squash all commit in single one and add comment to the commit message. I saw that you've added a comment in the issue describing the problem and the solution but would be great if you add that to the commit message as well.
src/main/java/org/codehaus/plexus/components/io/attributes/FileAttributes.java
Outdated
Show resolved
Hide resolved
src/main/java/org/codehaus/plexus/components/io/attributes/FileAttributes.java
Outdated
Show resolved
Hide resolved
src/main/java/org/codehaus/plexus/components/io/attributes/FileAttributes.java
Outdated
Show resolved
Hide resolved
Just need to figure out how to squash the commits and push it to same pull request |
839e2d0
to
bbf56a0
Compare
Improves performance on systems which has high time penalty when fetching owner and group name.
bbf56a0
to
48d608b
Compare
Now I think I got it right :) thanks for the patience. |
Looks great. Thanks again for your contribution. |
No problem, did you miss merging the pull request? |
Ah, saw now that it was merged, strange message in github however |
That it because I've merged it locally and I've changed the commit message (amended your commit) to include the closes keywords. That makes the merge looks strange in GitHub (because of the amended commit technically it is not merged). I guess I'll have to look about another way to do the merges as this is really a bit confusing. |
A fix for #16