Skip to content

Fixing issue performance of group and owner file attribute cache which was introduced in 2.6.1 #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Classe
Copy link
Contributor

@Classe Classe commented Nov 19, 2018

A fix for #16

@Classe
Copy link
Contributor Author

Classe commented Nov 19, 2018

Is this fix okay from your point of view? Asking if I should attend fixing the rest of the builds

@Classe Classe changed the title Fixing performance of group and owner file attribute cache introduced in 2.6.1 Fixing issue performance of group and owner file attribute cache which was introduced in 2.6.1 Nov 19, 2018
@Classe
Copy link
Contributor Author

Classe commented Nov 19, 2018

@plamentotev @krosenvold what do you think about this?

@plamentotev
Copy link
Member

Hi,
Thank you for the contribution. Really appreciate it that you took your time to investigate and share back with the community. Those kind of problems are quite hard to spot and find especially when they manifest only on certain configurations.

I can take a look latter this week, but in general the changes look ok.

@michael-o
Copy link
Member

The question is: why does unix:* incur so much overhead? We are likely fixing the symptom, but not the real cause.

@Classe
Copy link
Contributor Author

Classe commented Nov 19, 2018

I would say that fetching group name and owner name can be lookup heavy on some systems with some security related to mapping group and owner name to gid/uid. This causes the issue together with the 2.6.1 that unintentionally disabled this naming lookup caching.

@olamy
Copy link
Member

olamy commented Nov 20, 2018

LGTM maybe you can write some jmh tests to compare. I'm happy to run them on a beefy machine.

@plamentotev plamentotev added this to the 3.1.1 milestone Nov 25, 2018
Copy link
Member

@plamentotev plamentotev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added some small comments. Also if you can squash all commit in single one and add comment to the commit message. I saw that you've added a comment in the issue describing the problem and the solution but would be great if you add that to the commit message as well.

@Classe
Copy link
Contributor Author

Classe commented Nov 26, 2018

Just need to figure out how to squash the commits and push it to same pull request

@Classe Classe force-pushed the fix/attribute-cache branch from 839e2d0 to bbf56a0 Compare November 26, 2018 07:35
Improves performance on systems which has high time penalty when fetching owner and group name.
@Classe Classe force-pushed the fix/attribute-cache branch from bbf56a0 to 48d608b Compare November 26, 2018 07:37
@Classe
Copy link
Contributor Author

Classe commented Nov 26, 2018

Now I think I got it right :) thanks for the patience.

@plamentotev
Copy link
Member

Looks great. Thanks again for your contribution.

@Classe
Copy link
Contributor Author

Classe commented Nov 27, 2018

No problem, did you miss merging the pull request?
"Closed with unmerged commits
This pull request is closed, but the Classe:fix/attribute-cache branch has unmerged commits"

@Classe
Copy link
Contributor Author

Classe commented Nov 27, 2018

Ah, saw now that it was merged, strange message in github however

@plamentotev
Copy link
Member

plamentotev commented Dec 2, 2018

That it because I've merged it locally and I've changed the commit message (amended your commit) to include the closes keywords. That makes the merge looks strange in GitHub (because of the amended commit technically it is not merged). I guess I'll have to look about another way to do the merges as this is really a bit confusing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants