Skip to content

Adding LC solution for 1544. Make The String Great #789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 9, 2024
Merged

Adding LC solution for 1544. Make The String Great #789

merged 6 commits into from
Jun 9, 2024

Conversation

aaradhyasinghgaur
Copy link
Contributor

@aaradhyasinghgaur aaradhyasinghgaur commented Jun 8, 2024 •
edited
Loading

Related Issue

Adding LC solution for 1544. Make The String Great

Description

Useful for user to be able to solve complex/hard problems similar to this whenever somebody want a solution for this.

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / Videos (if applicable)

[Attach any relevant screenshots or videos demonstrating the changes]

Checklist

  • I have performed a self-review of my code.
  • I have read and followed the Contribution Guidelines.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional Context

[Include any additional information or context that might be helpful for reviewers.]

Resources for Guidance

Here are some resources that may be helpful as you contribute to CodeHarborHub:

Resources for DSA Features on Our Site:

@deepsource-io deepsource.io
Copy link
Contributor

deepsource-io bot commented Jun 8, 2024 •
edited
Loading

Here's the code health analysis summary for commits cb56b9c..43fb210. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jun 8, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
28.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@ajay-dhangar ajay-dhangar added documentation Improvements or additions to documentation GSSOC'24 GirlScript Summer of Code | Contributor level2 GirlScript Summer of Code | Contributor's Levels gssoc GirlScript Summer of Code | Contributor labels Jun 9, 2024
@ajay-dhangar ajay-dhangar linked an issue Jun 9, 2024 that may be closed by this pull request
[Feature Request]: Adding LC solution for 1544. Make The String Great #708
Closed
4 tasks
ajay-dhangar
ajay-dhangar requested changes Jun 9, 2024
View reviewed changes
Copy link
Member

@ajay-dhangar ajay-dhangar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update code based on suggestions

ajay-dhangar
ajay-dhangar requested changes Jun 9, 2024
View reviewed changes
Copy link
Member

@ajay-dhangar ajay-dhangar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update your cade in line 43 remove </ br> or if you want to use then try <br /> for best practice

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jun 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

ajay-dhangar
ajay-dhangar approved these changes Jun 9, 2024
View reviewed changes
Copy link
Member

@ajay-dhangar ajay-dhangar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@ajay-dhangar ajay-dhangar merged commit 244ee88 into codeharborhub:main Jun 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajay-dhangar ajay-dhangar ajay-dhangar approved these changes

Assignees

@aaradhyasinghgaur aaradhyasinghgaur

Labels
documentation Improvements or additions to documentation gssoc GirlScript Summer of Code | Contributor GSSOC'24 GirlScript Summer of Code | Contributor level2 GirlScript Summer of Code | Contributor's Levels
Projects
@CodeHarborHub
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Adding LC solution for 1544. Make The String Great
2 participants
@aaradhyasinghgaur @ajay-dhangar