Skip to content

4 section added in css #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 4, 2024
Merged

4 section added in css #502

merged 2 commits into from
Jun 4, 2024

Conversation

Yashgabani845
Copy link
Contributor

Related Issue

Fixes #398

Description

as per i said in issue i have added

  • css padding
  • css margin
  • css outline
  • css border
    these sections and one more thing there was no format in CSS before this so i have done in best formar
    you can refer it to others if you like it
    i have working video you an refer it

Type of PR

  • Feature enhancement
  • Documentation update

Screenshots / Videos (if applicable)

bandicam.2024-06-04.11-47-00-020.mp4

Checklist

  • I have performed a self-review of my code.
  • I have read and followed the Contribution Guidelines.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional Context

as always i tried to maintain best quality but if you want to change anything
always there for you to improve
and label it whatever you thing about contribute

Resources for Guidance

Here are some resources that may be helpful as you contribute to CodeHarborHub:

Resources for DSA Features on Our Site:

Copy link

vercel bot commented Jun 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
codeharborhub-github-io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2024 6:31am

Copy link
Contributor

deepsource-io bot commented Jun 4, 2024

Here's the code health analysis summary for commits e573f82..4db6dc1. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@Yashgabani845
Copy link
Contributor Author

Yashgabani845 commented Jun 4, 2024

@ajay-dhangar
i have added css sections
i have small request for you
please do not assign more than 3/4 issue to 1 person at a time
litrally people are spamming on your repo. it is making trouble toyou and us also,
and solution of 1 leetcode or gfg problem or one docs section is getting level 2 which is not deserved i have also put soution of kadane but it is not taking much time to make so give it level 1 i am also ready if you give my gfg/leetcode solution level 1

@ajay-dhangar ajay-dhangar added documentation Improvements or additions to documentation GSSOC'24 GirlScript Summer of Code | Contributor gssoc GirlScript Summer of Code | Contributor labels Jun 4, 2024
@ajay-dhangar
Copy link
Member

@ajay-dhangar i have added css sections i have small request for you please do not assign more than 3/4 issue to 1 person at a time litrally people are spamming on your repo. it is making trouble toyou and us also, and solution of 1 leetcode or gfg problem or one docs section is getting level 2 which is not deserved i have also put soution of kadane but it is not taking much time to make so give it level 1 i am also ready if you give my gfg/leetcode solution level 1

Thanks for your feedback I will assign level based on work/time.

@ajay-dhangar ajay-dhangar added the level2 GirlScript Summer of Code | Contributor's Levels label Jun 4, 2024
Copy link
Member

@ajay-dhangar ajay-dhangar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now, change your all files code based on suggestions

Copy link

vercel bot commented Jun 4, 2024

Deployment failed with the following error:

Resource is limited - try again in 16 minutes (more than 100, code: "api-deployments-free-per-day").

Copy link

sonarqubecloud bot commented Jun 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Yashgabani845
Copy link
Contributor Author

Yashgabani845 commented Jun 4, 2024

@ajay-dhangar done with the changes
it looks very good now thank you for your feedback

Copy link
Member

@ajay-dhangar ajay-dhangar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@Yashgabani845
Copy link
Contributor Author

@ajay-dhangar can you please proceed merge if there is no issue

@ajay-dhangar
Copy link
Member

@Yashgabani845 The site is under maintenance today due to a high volume of test requests. As a result, our queue is currently full. Therefore, I won't be able to merge any contributor PRs today. Once the issue is resolved, I will review and merge all pending PRs. I apologize for the inconvenience and appreciate your patience.

@Yashgabani845
Copy link
Contributor Author

Yashgabani845 commented Jun 4, 2024

@ajay-dhangar don't worry thank you for responding

@ajay-dhangar ajay-dhangar merged commit d77a891 into codeharborhub:main Jun 4, 2024
6 of 7 checks passed
@sanjay-kv sanjay-kv added level1 GirlScript Summer of Code | Contributor's Levels and removed level2 GirlScript Summer of Code | Contributor's Levels labels Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation gssoc GirlScript Summer of Code | Contributor GSSOC'24 GirlScript Summer of Code | Contributor level1 GirlScript Summer of Code | Contributor's Levels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Adding Sections in CSS
3 participants