Skip to content

NextJs docs has been added #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 3, 2024
Merged

NextJs docs has been added #360

merged 11 commits into from
Jun 3, 2024

Conversation

Aksshay88
Copy link
Contributor

Related Issue

#359

Description

I have added the Next js docs from the scratch where user could see from the first how to download the Nextjs and app routing ,page routing , architecture

Type of PR

  • Feature enhancement

Screenshots / Videos (if applicable)

[Attach any relevant screenshots or videos demonstrating the changes]
image
image

Checklist

  • I have read and followed the Contribution Guidelines.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional Context

[Include any additional information or context that might be helpful for reviewers.]

Resources for Guidance

Here are some resources that may be helpful as you contribute to CodeHarborHub:

Resources for DSA Features on Our Site:

@Aksshay88 Aksshay88 requested a review from ajay-dhangar as a code owner June 2, 2024 12:35
Copy link

vercel bot commented Jun 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
codeharborhub-github-io 🛑 Canceled (Inspect) Jun 3, 2024 7:00am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there! 👋 Thank you for submitting your first pull request to CodeHarborHub. We appreciate your contribution! Our team will review it soon. If you have any questions or need further assistance, feel free to reach out.

Copy link
Contributor

deepsource-io bot commented Jun 2, 2024

Here's the code health analysis summary for commits f52e5b2..f9f3531. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@Aksshay88
Copy link
Contributor Author

Pls do add the GSSOC Label

@ajay-dhangar ajay-dhangar added documentation Improvements or additions to documentation GSSOC'24 GirlScript Summer of Code | Contributor level2 GirlScript Summer of Code | Contributor's Levels gssoc GirlScript Summer of Code | Contributor labels Jun 2, 2024
@ajay-dhangar ajay-dhangar linked an issue Jun 2, 2024 that may be closed by this pull request
4 tasks
Copy link
Member

@ajay-dhangar ajay-dhangar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make Sure, You follow our structure

Resources for Guidance

Here are some resources that may be helpful as you contribute to CodeHarborHub:

Resources for DSA Features on Our Site:

@Aksshay88
Copy link
Contributor Author

@ajay-dhangar Sorry For making it a mistake Now I resolved the changes you have mentioned .You could check it now .Thanks in advance.

@Aksshay88 Aksshay88 requested a review from ajay-dhangar June 2, 2024 13:02
Copy link
Contributor Author

@Aksshay88 Aksshay88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have changed the suggestion you have asked for .Thanks in advance.Happy Hacking

@Aksshay88
Copy link
Contributor Author

@ajay-dhangar Just now saw what the problem is that docker cli is not identifying my image from the format of webp

Now I have added it in a local format where it could identify the image and it could run without error

I request you to run it again or review the changes I have made.Thank you

Copy link
Member

@ajay-dhangar ajay-dhangar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change for best practice

@@ -0,0 +1,66 @@
---
id: Next JS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

id put like next-js

@@ -0,0 +1,66 @@
---
id: Next JS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

id put like next-js

Edit `app/page.tsx` (or `pages/index.tsx`) file and save it to see the updated result in your browser.


<a href="https://nextjs.org/docs/app"><img src="https://github.com/Aksshay88/Macbook/assets/119944779/1c389169-463a-42e1-b4f0-28830ed4b8a8"></a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bad Practice:

<img src="img.png">

Good Practice:

<img src="img.png" alt="Image name" />

@Aksshay88
Copy link
Contributor Author

Aksshay88 commented Jun 2, 2024

@ajay-dhangar sure will change it and get back to you ASAP

Thanks in advance

Copy link
Member

@ajay-dhangar ajay-dhangar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is fine. Please focus on XML/JSX syntax best practices.

```
After the prompts, `create-next-app` will create a folder with your project name and install the required dependencies.

Create a root layout inside `app/layout.tsx` with the required `<html>` and ``<body>`` tags:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bade Practice:

``<body>``

Good Practice:

`<body>`

Edit `app/page.tsx` (or `pages/index.tsx`) file and save it to see the updated result in your browser.


<a href="https://nextjs.org/docs/app"><img src="emty.png"></a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bad Practice:

<img src="empty.png">

Good Practice:

<img src="empty.png" />

In JSX, all tags must be self-closing, so it's important to add the closing slash to the <img> tag.

@Aksshay88 Aksshay88 requested a review from ajay-dhangar June 3, 2024 05:12
@Aksshay88
Copy link
Contributor Author

@ajay-dhangar Completed changing it .I hope your suggestion that you have requested has been rectified and thanks in advance .

Copy link
Member

@ajay-dhangar ajay-dhangar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done and fixed issues but content is not good so, next time write more better.

Copy link

sonarqubecloud bot commented Jun 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@ajay-dhangar ajay-dhangar merged commit e662cd0 into codeharborhub:main Jun 3, 2024
6 of 7 checks passed
@Aksshay88
Copy link
Contributor Author

@ajay-dhangar Sure Next time will write the content in a detailed manner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation gssoc GirlScript Summer of Code | Contributor GSSOC'24 GirlScript Summer of Code | Contributor level2 GirlScript Summer of Code | Contributor's Levels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Next Js Docs
2 participants