Skip to content

javascript docs addded #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 2, 2024
Merged

javascript docs addded #352

merged 3 commits into from
Jun 2, 2024

Conversation

Yashgabani845
Copy link
Contributor

Related Issue

Fixes #339

Description

As per i said in my issue i have added 5 sections
beacuse of conditional statement was already implemented i have added 2 other sections

sections

  1. Array Methods
  2. do-while loop
  3. Web APIs
  4. Client frameworks
  5. Object Constructor

Type of PR

  • Feature enhancement
  • Documentation update

Screenshots / Videos (if applicable)

Screenshot (317)
Screenshot (320)
Screenshot (321)
Screenshot (322)
Screenshot (323)

[Attach any relevant screenshots or videos demonstrating the changes]

Checklist

  • I have performed a self-review of my code.
  • I have read and followed the Contribution Guidelines.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional Context

tried to maintain code quality

Resources for Guidance

Here are some resources that may be helpful as you contribute to CodeHarborHub:

Resources for DSA Features on Our Site:

Copy link

vercel bot commented Jun 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
codeharborhub-github-io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 2, 2024 9:58am

@Yashgabani845
Copy link
Contributor Author

@ajay-dhangar
added 5 sections in js docs please check it

Copy link
Contributor

deepsource-io bot commented Jun 2, 2024

Here's the code health analysis summary for commits 752e80e..b5db7c0. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@ajay-dhangar ajay-dhangar added documentation Improvements or additions to documentation GSSOC'24 GirlScript Summer of Code | Contributor level2 GirlScript Summer of Code | Contributor's Levels gssoc GirlScript Summer of Code | Contributor labels Jun 2, 2024
Copy link
Member

@ajay-dhangar ajay-dhangar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change code based on suggestions

@@ -0,0 +1,281 @@
---
id: Object Constructor
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bad practice:

id: Object Constructor

Good Practice:

id: 0bject-constructor

this.gg = C;
}
```
Here, `GFG` is the constructor name and `A`, `B`, `C` are the arguments of the constructor.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please modify the example so that it does not use any content from the existing site. We need to create something unique for our use.

#### Example 1: Using `new` Keyword and Dot Operator

```javascript
// Creating object using "new" keyword
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, change it

Author: GeeksforGeeks
```

#### Example 2: Using Curly Braces and Bracket Notation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put for us not use GFG we can use reference but not use content of other site.

@ajay-dhangar ajay-dhangar added level3 GirlScript Summer of Code | Contributor's Levels and removed level2 GirlScript Summer of Code | Contributor's Levels labels Jun 2, 2024
Copy link

sonarqubecloud bot commented Jun 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Yashgabani845
Copy link
Contributor Author

@ajay-dhangar i have changed al the examples which i have taken from gfg
i usually prefer to read official docs and use content but i did not found much details about object constructor there that's why.
but i will keep this thing in mind next time

Copy link
Member

@ajay-dhangar ajay-dhangar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, Done

@ajay-dhangar ajay-dhangar merged commit 0428cfb into codeharborhub:main Jun 2, 2024
8 checks passed
@sanjay-kv sanjay-kv added level1 GirlScript Summer of Code | Contributor's Levels and removed level3 GirlScript Summer of Code | Contributor's Levels labels Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation gssoc GirlScript Summer of Code | Contributor GSSOC'24 GirlScript Summer of Code | Contributor level1 GirlScript Summer of Code | Contributor's Levels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Adding Sections in Javascript
3 participants