-
-
Notifications
You must be signed in to change notification settings - Fork 157
Leetcode Solution 4 to 10 added #332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Here's the code health analysis summary for commits Analysis Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there! 👋 Thank you for submitting your first pull request to CodeHarborHub. We appreciate your contribution! Our team will review it soon. If you have any questions or need further assistance, feel free to reach out.
@ajay-dhangar please review this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your work is good, but there are some changes you can make to follow best practices.
dsa-solutions/lc-solutions/0000-0099/0004-Median-of-two-Sorted-Array.md
Outdated
Show resolved
Hide resolved
|
||
### Solution | ||
|
||
#### Approach 1: Merge Sort (O(m + n)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replace (O(m + n))
to $$(O(m + n))$$
- Approach 2: O(log(min(m, n))) because it performs binary search on the smaller array. | ||
|
||
- **Space Complexity:** | ||
- Approach 1: O(m + n) due to the additional space needed for the merged array. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replace O(m + n)
to $$O(m + n)$$
|
||
- **Space Complexity:** | ||
- Approach 1: O(m + n) due to the additional space needed for the merged array. | ||
- Approach 2: O(1) because it uses only a constant amount of additional space. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replace O(1) to $$O(1)$$
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And you change for every files or codes for best practice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think you are trying to say
to replace with
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ajay-dhangar added all signs btw i have added 1 $ because $$ was changing alignment and making it ugly
okay |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Related Issue
[Feature Request]: DSA solution 4 to 10 #324
Fixes : #324
Description
As pr you said i have tried my best to maintain the quality of the code and tried to add all of the sections
which are in first 3 solutions
i have added 7 solutions with sections like :
i hope it is enough
Type of PR
Screenshots / Videos (if applicable)
[Attach any relevant screenshots or videos demonstrating the changes]
Checklist
Additional Context
i followed instaruction as you said
i hope quality of this code impressed you
thank you
Resources for Guidance
Here are some resources that may be helpful as you contribute to CodeHarborHub:
Resources for DSA Features on Our Site: