Skip to content

Added CSS in docs #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 1, 2024
Merged

Added CSS in docs #314

merged 10 commits into from
Jun 1, 2024

Conversation

AmrutaJayanti
Copy link
Contributor

Related Issue

#300

Description

I have added css in docs and created a readme.md file which includes the tutorials to be added under CSS.
I added the basic-syntax and selectors from css

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): Added CSS

Checklist

  • I have performed a self-review of my code.
  • I have read and followed the Contribution Guidelines.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Resources for Guidance

Here are some resources that may be helpful as you contribute to CodeHarborHub:

Resources for DSA Features on Our Site:

Copy link

vercel bot commented May 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
codeharborhub-github-io ✅ Ready (Inspect) Visit Preview 💬 1 unresolved Jun 1, 2024 2:12am

Copy link
Contributor

deepsource-io bot commented May 31, 2024

Here's the code health analysis summary for commits 09bd17b..29ce6aa. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@ajay-dhangar ajay-dhangar added documentation Improvements or additions to documentation GSSOC'24 GirlScript Summer of Code | Contributor level2 GirlScript Summer of Code | Contributor's Levels gssoc GirlScript Summer of Code | Contributor labels May 31, 2024
@ajay-dhangar ajay-dhangar linked an issue May 31, 2024 that may be closed by this pull request
Copy link
Member

@ajay-dhangar ajay-dhangar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To maintain consistency and ease of maintenance in our content, please follow the structure outlined in our previous tutorials. Adhering to this format ensures good practice and uniformity.

@AmrutaJayanti
Copy link
Contributor Author

@ajay-dhangar Can I create another folder which has CSS-basics in docs/CSS and add these in it. So that other CSS related like CSS animations, About bootstrap could be added later

@ajay-dhangar
Copy link
Member

@ajay-dhangar Can I create another folder which has CSS-basics in docs/CSS and add these in it. So that other CSS related like CSS animations, About bootstrap could be added later

Yes, absolutely! We need to create superior content to stand out among the best sites out there. Our goal is to provide valuable content that is not only high-quality but also free of charge and ad-free, setting us apart from the competition.

@AmrutaJayanti
Copy link
Contributor Author

@ajay-dhangar I made the changes. Please approve

Copy link
Member

@ajay-dhangar ajay-dhangar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now change code in readme.md file based on suggestion.


2. Internal CSS:

Defined within a <style> tag in the HTML document's <head>.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bad practice:

 Defined within a <style> tag in the HTML document's <head>.

Good Practice:

Defined within a `<style>` tag in the HTML document's `<head>`.

Copy link

sonarqubecloud bot commented Jun 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@AmrutaJayanti
Copy link
Contributor Author

@ajay-dhangar I made changes. Please approve

Copy link
Member

@ajay-dhangar ajay-dhangar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your contribution is appreciated, but it does not align well with the structure and value of my site’s content. Next time, please improve the quality of your content for better understanding and greater value.

@ajay-dhangar ajay-dhangar merged commit 9cf4e35 into codeharborhub:main Jun 1, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation gssoc GirlScript Summer of Code | Contributor GSSOC'24 GirlScript Summer of Code | Contributor level2 GirlScript Summer of Code | Contributor's Levels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add CSS
2 participants