Skip to content

Added "Licensing Page" Reflecting "MIT License" #2130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

aslams2020
Copy link
Contributor

@aslams2020 aslams2020 commented Jun 26, 2024

Hey @ajay-dhangar ,
issue closes #2116

I wanted to discuss the recent issue I resolved regarding adding the Licensing page with the MIT License to the website's footer.

What I Did ?

  • I have added a dedicated "Licensing Page" that reflects the use of the MIT License.
  • Also, Added Accessible link to the license section in home page.
  • Integrated Footer.

Video

Please take a look at the video below -

C.mp4

Also @ajay-dhangar, Would it be possible to update the label to level2 (if possible) ?
I believe this adjustment would better reflect the effort applied in resolving the issue.

Looking forward to your feedback on this. Thank you for considering my request.

Type of PR

  • Feature enhancement

Checklist

  • I have tested the changes thoroughly before submitting this pull request.
  • I have performed a self-review of my code.
  • I have read and followed the Contribution Guidelines.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have followed the code style guidelines of this project.
  • I have checked for any existing open issues that my pull request may address.
  • I have ensured that my changes do not break any existing functionality.
  • Each contributor is allowed to create a maximum of 4 issues per day. This helps us manage and address issues efficiently.
  • I have read the resources for guidance listed below.
  • I have followed security best practices in my code changes.

Resources for Guidance

Please read the following resources before submitting your contribution:

@aslams2020 aslams2020 requested a review from ajay-dhangar as a code owner June 26, 2024 16:44
Copy link
Contributor

deepsource-io bot commented Jun 26, 2024

Here's the code health analysis summary for commits d905b0c..efb9914. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript❌ Failure
❗ 4 occurences introduced
View Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @aslams2020! 👋 Thank you for submitting your first pull request to CodeHarborHub. Great job on the contribution! 🎉 We appreciate your efforts and our team will review it soon. If you have any questions or need further assistance, feel free to reach out. Keep up the great work!

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @aslams2020! 🎉 Thank you for submitting your pull request to CodeHarborHub. We appreciate your contribution and enthusiasm! Our team will review it soon. If you have any questions or need further assistance, feel free to reach out. Thanks for contributing!

@aslams2020
Copy link
Contributor Author

@ajay-dhangar

@ajay-dhangar ajay-dhangar added documentation Improvements or additions to documentation GSSOC'24 GirlScript Summer of Code | Contributor level1 GirlScript Summer of Code | Contributor's Levels gssoc GirlScript Summer of Code | Contributor javascript Pull requests that update Javascript code labels Jun 27, 2024
Copy link
Member

@ajay-dhangar ajay-dhangar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@ajay-dhangar ajay-dhangar merged commit 48b6c55 into codeharborhub:main Jun 27, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation gssoc GirlScript Summer of Code | Contributor GSSOC'24 GirlScript Summer of Code | Contributor javascript Pull requests that update Javascript code level1 GirlScript Summer of Code | Contributor's Levels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature 🌟: Add "Licensing Page" Reflecting "MIT Licence"
2 participants