Added Code of Conduct and Cookie Policy Page #207
Conversation
Signed-off-by: Hemashree M S <hemashree21.msh@gmail.com>
Signed-off-by: Hemashree M S <hemashree21.msh@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Here's the code health analysis summary for commits Analysis Summary
|
Signed-off-by: Hemashree M S <hemashree21.msh@gmail.com>
Signed-off-by: Hemashree M S <hemashree21.msh@gmail.com>
Signed-off-by: Hemashree M S <hemashree21.msh@gmail.com>
|
@ajay-dhangar The Deepsource: JavaScript is showing deepnesting error so the check is not passing. If I have to resolve that I have to rewrite the complete code. Is it compulsory to pass all the checks here and will it create some conflict if not resolved? If I need to resolve it I will do it tomorrow. |
Signed-off-by: Hemashree M S <hemashree21.msh@gmail.com>
ajay-dhangar
added
documentation
src/pages/cookie-policy/index.tsx
Outdated
| padding: 20px; | ||
| border-radius: 5px; | ||
| box-shadow: 0 0 10px 0 rgba(0, 0, 0, 0.1); | ||
| margin-top: 20px; |
There was a problem hiding this comment.
remove margin-top: 20px; , margin-bottom: 20px; and update margin: 20px auto;
src/pages/cookie-policy/index.tsx
Outdated
| * Cookie Section | ||
| **/ | ||
|
|
||
| const CookieSection = ({ title, children }) => ( |
There was a problem hiding this comment.
in the case of tsx you need to define react function for example
bad practices
const CookieSection = ({ title, children }) => (
<section>
<SubTitle>{title}</SubTitle>
{children}
</section>
);good practices
const CookieSection: React.FC = ({ title, children }) => {
return (
<section>
<SubTitle>{title}</SubTitle>
{children}
</section>
);
};
src/pages/cookie-policy/index.tsx
Outdated
| * Cookie Policy | ||
| **/ | ||
|
|
||
| const Cookiepolicy = () => { |
There was a problem hiding this comment.
also define const Cookiepolicy = () => { to const Cookiepolicy: React.FC = () => {
Signed-off-by: Hemashree M S <hemashree21.msh@gmail.com>
Signed-off-by: Hemashree M S <hemashree21.msh@gmail.com>
|
|
@ajay-dhangar I resolved all issues and made the changes as suggested |
Resolves issue #201. I have added the Code of Conduct and Cookie Policy page, both are in the same format as the Privacy Policy page.
@ajay-dhangar please check once