Skip to content

Added FizzBuzz,WaterBottle,SignOf and BrokenCal Solution In Java #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 4, 2021

Conversation

Manish-kasera
Copy link
Contributor

@Manish-kasera Manish-kasera commented Oct 1, 2021

Pull Request Template

Description

Please include a summary of the problem and about the approach to solve the solution. Please also include relevant motivation and context.
List any dependencies that are required for this change.

Put check marks:

Have you made changes in README file ?

  • Added problem & solution under correct topic.
  • Specified Space & Time complexity.
  • Specified difficulty level, tag & Note(if any).

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • Test A
  • Test B

Make sure all below guidelines are followed else PR will get Reject:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code so that it is easy to understand
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@welcome
Copy link

welcome bot commented Oct 1, 2021

I can tell this is your first pull request! Thank you I'm so honored. 🎉🎉🎉 I'll take a look at it ASAP!

Copy link
Member

@GouravRusiya30 GouravRusiya30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Don't add main methods
  • Remove un-necessary package names
  • Update README with Problem link and Time/Space Complexity

@Manish-kasera
Copy link
Contributor Author

Okay @GouravRusiya30 I am sure do that

@Manish-kasera
Copy link
Contributor Author

I had made the changes would you please review it
.

@GouravRusiya30
Copy link
Member

@Manish-kasera
README file is not updated with correct problem link and time, space complexity

@Manish-kasera
Copy link
Contributor Author

Updated Readme.md File.... Hope everything is Correct @GouravRusiya30

@Manish-kasera
Copy link
Contributor Author

@GouravRusiya30 review it please.

@GouravRusiya30 GouravRusiya30 merged commit 87caedc into codedecks-in:master Oct 4, 2021
@welcome
Copy link

welcome bot commented Oct 4, 2021

Your code looks great! Congrats, I've gone ahead and merged your first pull request! Keep it up! alt text

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Submit your first PR by solving a Leetcode problem
2 participants