Upgrade rubocop to fix Style/WordArray warning. #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdiggs
force-pushed
the
upgrade-rubocop
branch
from
94e84f4 to
dc822f7
Compare
|
@ABaldwinHunter does this interfere with your points work? |
| @@ -61,3 +63,6 @@ DEPENDENCIES | |||
| rubocop | |||
| rubocop-rspec | |||
| safe_yaml | |||
|
|
|||
| BUNDLED WITH | |||
| 1.10.6 | |||
There was a problem hiding this comment.
Is the Bundled with addition intentional or impactful?
There was a problem hiding this comment.
Neither. Will remove though
A few users have run into this problem, and upgrading rubocop (specifically the parsing dependencies) fixes the issue. Example engine output is shown below. Before this change ================== ``` An error occurred while Style/WordArray cop was inspecting config/initializers/logs.rb. To see the complete backtrace run rubocop -d. ``` After this change ================= ``` warning: parser/current is loading parser/ruby22, which recognizes warning: 2.2.3-compliant syntax, but you are running 2.2.2. warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri. ``` Note: this version warning is new, but as there were no syntax changes introduced in ruby 2.2.3, I don't believe it is an issue. (https://www.ruby-lang.org/en/news/2015/08/18/ruby-2-2-3-released/)
gdiggs
force-pushed
the
upgrade-rubocop
branch
from
dc822f7 to
dec3082
Compare
|
@gordondiggs I don't think it interferes. Minor comment but LGTM |
|
Also, the points work is already merged |
|
Thanks for heads up |
gdiggs
added a commit
that referenced
this pull request
Dec 29, 2015
Upgrade rubocop to fix Style/WordArray warning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few users have run into this problem, and upgrading rubocop
(specifically the parsing dependencies) fixes the issue. Example engine
output is shown below.
Before this change
After this change
Note: this version warning is new, but as there were no syntax changes
introduced in ruby 2.2.3, I don't believe it is an issue.
(https://www.ruby-lang.org/en/news/2015/08/18/ruby-2-2-3-released/)
@codeclimate/review