Add category for check new in 2.3 #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the update to PHPMD 2.3, we see invalid index warnings since this check is not in our category map. The warnings don't cause errors and we fall through to a default Style category and remediation, but these are more appropriate values. The values were chosen as the same as the too-many-methods check, by the reasoning that the general task of reducing the size of objects is the same remediation no matter the methods' visibilities. Note: we don't currently have the facility to scale remediation by overage, which would make sense in this case, but adding that has been deferred for now. http://phpmd.org/rules/codesize.html#toomanypublicmethods
|
LGTM |
Something is either intentionally changed or broken in edge when resolving dependencies, readline and libxml2 are not installed, causing php to segfault. Building from edge is dangerous for exactly these reasons. This patch fixes the tag to 3.3 (the latest released version of alpine at this time), which still builds correctly.
pbrisbin
force-pushed
the
pb-too-many-methods
branch
from
c39c674 to
0530930
Compare
pbrisbin
added a commit
that referenced
this pull request
Feb 10, 2016
Add category for check new in 2.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the update to PHPMD 2.3, we see invalid index warnings since this check
is not in our category map. The warnings don't cause errors and we fall through
to a default Style category and remediation, but these are more appropriate
values.
The values were chosen as the same as the too-many-methods check, by the
reasoning that the general task of reducing the size of objects is the same
remediation no matter the methods' visibilities. Note: we don't currently have
the facility to scale remediation by overage, which would make sense in this
case, but adding that has been deferred for now.
http://phpmd.org/rules/codesize.html#toomanypublicmethods
/cc @codeclimate/review