Remove docker login step from Circle yml #329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the docker login step from our Circle yml. The idea is that this is pulling the parser image, which was private when we added this step. However, the parser image is now public. This is also blocking OSS contributions from users who have forked duplication, since Circle fails at this step on forks. Co-authored-by: Max Jacobson <max@hardscrabble.net>
|
That theory sounds right to me, and the fact that this is green seems like pretty good evidence that the line isn't necessary. Seems like we should merge this, then encourage OSS contributors to rebase on top of master |
maxjacobson
approved these changes
Jul 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the docker login step from our Circle yml. The idea is
that this is pulling the parser image, which was private when we added
this step. However, the parser image is now public.
This is also blocking OSS contributions from users who have forked
duplication, since Circle fails at this step on forks.
Co-authored-by: Max Jacobson max@hardscrabble.net