Adjust DEFAULT_MASS_THRESHOLD and POINTS_PER_OVERAGE #301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeclimate-hermes
requested review from
wfleming
and removed request for
codeclimate-hermes
wfleming
approved these changes
Dec 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix sets the
DEFAULT_MASS_THRESHOLDto 100 and thePOINTS_PER_OVERAGEto 10,000, which is more reasonable based on the Go AST.The previous
DEFAULT_MASS_THRESHOLDwas simply too low and allowing tiny issues to be flagged as duplication. Similarly, the previousPOINTS_PER_OVERAGEwas too high and was representing a time-to-fix that was abnormally long.