Skip to content

fix: disable retryFailedStep when using with tryTo #4022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2023
Merged

fix: disable retryFailedStep when using with tryTo #4022

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/plugin/retryFailedStep.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
const event = require('../event');
const recorder = require('../recorder');
const container = require('../container');

const defaultConfig = {
retries: 3,
Expand Down Expand Up @@ -98,6 +99,8 @@ module.exports = (config) => {
config.when = when;

event.dispatcher.on(event.step.started, (step) => {
if (container.plugins('tryTo')) return;

// if a step is ignored - return
for (const ignored of config.ignoredSteps) {
if (step.name === ignored) return;
Expand Down
22 changes: 11 additions & 11 deletions test/unit/plugin/retryFailedStep_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ describe('retryFailedStep', () => {
event.dispatcher.emit(event.step.started, { name: 'click' });

let counter = 0;
recorder.add(() => {
await recorder.add(() => {
counter++;
if (counter < 3) {
throw new Error();
Expand All @@ -51,7 +51,7 @@ describe('retryFailedStep', () => {
});
await recorder.promise();
} catch (e) {
recorder.catchWithoutStop((err) => err);
await recorder.catchWithoutStop((err) => err);
}

// expects to retry only once
Expand All @@ -65,15 +65,15 @@ describe('retryFailedStep', () => {
let counter = 0;
event.dispatcher.emit(event.step.started, { name: 'waitForElement' });
try {
recorder.add(() => {
await recorder.add(() => {
counter++;
if (counter < 3) {
throw new Error();
}
}, undefined, undefined, true);
await recorder.promise();
} catch (e) {
recorder.catchWithoutStop((err) => err);
await recorder.catchWithoutStop((err) => err);
}

expect(counter).to.equal(1);
Expand All @@ -87,15 +87,15 @@ describe('retryFailedStep', () => {
let counter = 0;
event.dispatcher.emit(event.step.started, { name: 'amOnPage' });
try {
recorder.add(() => {
await recorder.add(() => {
counter++;
if (counter < 3) {
throw new Error();
}
}, undefined, undefined, true);
await recorder.promise();
} catch (e) {
recorder.catchWithoutStop((err) => err);
await recorder.catchWithoutStop((err) => err);
}

expect(counter).to.equal(1);
Expand All @@ -109,15 +109,15 @@ describe('retryFailedStep', () => {
let counter = 0;
event.dispatcher.emit(event.step.started, { name: 'somethingNew' });
try {
recorder.add(() => {
await recorder.add(() => {
counter++;
if (counter < 3) {
throw new Error();
}
}, undefined, undefined, true);
await recorder.promise();
} catch (e) {
recorder.catchWithoutStop((err) => err);
await recorder.catchWithoutStop((err) => err);
}

expect(counter).to.equal(1);
Expand All @@ -131,15 +131,15 @@ describe('retryFailedStep', () => {
let counter = 0;
event.dispatcher.emit(event.step.started, { name: 'somethingNew' });
try {
recorder.add(() => {
await recorder.add(() => {
counter++;
if (counter < 3) {
throw new Error();
}
}, undefined, undefined, true);
await recorder.promise();
} catch (e) {
recorder.catchWithoutStop((err) => err);
await recorder.catchWithoutStop((err) => err);
}

expect(counter).to.equal(1);
Expand All @@ -161,7 +161,7 @@ describe('retryFailedStep', () => {
});
await recorder.promise();
} catch (e) {
recorder.catchWithoutStop((err) => err);
await recorder.catchWithoutStop((err) => err);
}

// expects to retry only once
Expand Down